Re: [RFC v2] mac80211: add unified BSS configuration

[Ivo van Doorn <ivdoorn@gmail.com>]

On Wednesday 26 December 2007, Johannes Berg wrote:
> This patch (based on Ron Rindjunsky's) creates a framework for
> a unified way to pass BSS configuration to drivers that require
> the information, e.g. for implementing power save mode.
> 
> A new ieee80211_bss_conf structure is embedded into each virtual
> interface structure to allow the driver to access the BSS
> configuration at any time, changes in the structure are passed
> to the driver via the new bss_info_changed() callback.
> 
> This new BSS configuration infrastructure adds the following
> new features:
>  * drivers are notified of their association AID
>  * drivers are notified of association status
> 
> and replaces the erp_ie_changed() callback. The patch also does
> the relevant driver updates for the latter change.
> 
> Signed-off-by: Ron Rindjunsky <ron.rindjunsky@intel.com>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> ---
> Before merging this needs to be amended by the correct rt2x00 change.
> Ivo, I can simply create a bss_conf structure there on the stack and
> hand that to the function, would that be an ok interim solution for you?

I couldn't apply your previous patch cleanly against latest wireless-dev. :S
Anyway, I looked into the patch and I think your fixme can be replaced with
a simple

rt2x00mac_bss_info_changed(rt2x00dev->hw,
						rt2x00dev->interface.vif,
						BSS_CHANGED_ERP_PREAMBLE);

That will make sure the behavior is the same as before, and I can implement
the  "assoc" boolean test later when this patch is merged.

> --- everything.orig/drivers/net/wireless/rt2x00/rt2x00dev.c	2007-12-23 10:41:46.025363388 +0100
> +++ everything/drivers/net/wireless/rt2x00/rt2x00dev.c	2007-12-23 11:29:14.125396538 +0100
> @@ -437,8 +437,10 @@ static void rt2x00lib_configuration_sche
>  	    container_of(work, struct rt2x00_dev, config_work);
>  	int preamble = !test_bit(CONFIG_SHORT_PREAMBLE, &rt2x00dev->flags);
>  
> -	rt2x00mac_erp_ie_changed(rt2x00dev->hw,
> +	/* !!FIXME FIXME FIXME!!
> +	rt2x00mac_bss_info_changed(rt2x00dev->hw,
>  				 IEEE80211_ERP_CHANGE_PREAMBLE, 0, preamble);
> +	*/
>  }

Ivo