rc80211_pid fails to remove debugfs files

rc80211_pid fails to remove debugfs files

[Michael Buesch]

The rc80211_pid fails to remove the debugfs files properly.
In debugfs I see phyX directories for PHYs that are long gone.
The only content is the rc80211_pid directory with its files.

Last time I looked through the PID code I saw that it does not
do proper error checking for the creation of debugfs files.
But error checking is important, as it _will_ otherwise result
in unpredicted behaviour. Debugfs is pretty nasty. :)
For example if creation of the root directory failed, it will
put the files all into the debugfs root. And yes, this _does_
happen. We had similiar problems and bugreports from people
in b43.

So please add errorchecking.

-- 
Greetings Michael.

Re: rc80211_pid fails to remove debugfs files

[Stefano Brivio]

On Sat, 29 Dec 2007 23:14:56 +0100
Michael Buesch <mb@bu3sch.de> wrote:

> The rc80211_pid fails to remove the debugfs files properly.
> In debugfs I see phyX directories for PHYs that are long gone.
> The only content is the rc80211_pid directory with its files.

Wait, this is fixed by:

Subject: [PATCH 4/7] rc80211-pid: fix sta_info refcounting

Fix a bug which caused uncorrect refcounting of PHYs in mac80211. Thanks to
Johannes Berg for spotting this out.

Cc: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Stefano Brivio <stefano.brivio@polimi.it>

(still not merged).


-- 
Ciao
Stefano