* rc80211_pid fails to remove debugfs files
@ 2007-12-29 22:14 Michael Buesch
2007-12-30 8:53 ` Stefano Brivio
0 siblings, 1 reply; 2+ messages in thread
From: Michael Buesch @ 2007-12-29 22:14 UTC (permalink / raw)
To: Stefano Brivio; +Cc: linux-wireless, Mattias Nissler
The rc80211_pid fails to remove the debugfs files properly.
In debugfs I see phyX directories for PHYs that are long gone.
The only content is the rc80211_pid directory with its files.
Last time I looked through the PID code I saw that it does not
do proper error checking for the creation of debugfs files.
But error checking is important, as it _will_ otherwise result
in unpredicted behaviour. Debugfs is pretty nasty. :)
For example if creation of the root directory failed, it will
put the files all into the debugfs root. And yes, this _does_
happen. We had similiar problems and bugreports from people
in b43.
So please add errorchecking.
--
Greetings Michael.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: rc80211_pid fails to remove debugfs files
2007-12-29 22:14 rc80211_pid fails to remove debugfs files Michael Buesch
@ 2007-12-30 8:53 ` Stefano Brivio
0 siblings, 0 replies; 2+ messages in thread
From: Stefano Brivio @ 2007-12-30 8:53 UTC (permalink / raw)
To: Michael Buesch; +Cc: linux-wireless, Mattias Nissler
On Sat, 29 Dec 2007 23:14:56 +0100
Michael Buesch <mb@bu3sch.de> wrote:
> The rc80211_pid fails to remove the debugfs files properly.
> In debugfs I see phyX directories for PHYs that are long gone.
> The only content is the rc80211_pid directory with its files.
Wait, this is fixed by:
Subject: [PATCH 4/7] rc80211-pid: fix sta_info refcounting
Fix a bug which caused uncorrect refcounting of PHYs in mac80211. Thanks to
Johannes Berg for spotting this out.
Cc: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Stefano Brivio <stefano.brivio@polimi.it>
(still not merged).
--
Ciao
Stefano
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-12-30 8:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-29 22:14 rc80211_pid fails to remove debugfs files Michael Buesch
2007-12-30 8:53 ` Stefano Brivio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).