From: Christoph Hellwig <hch@infradead.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Christoph Hellwig <hch@infradead.org>,
Sam Ravnborg <sam@ravnborg.org>,
Stefano Brivio <stefano.brivio@polimi.it>,
linux-wireless <linux-wireless@vger.kernel.org>,
Michael Wu <flamingice@sourmilk.net>,
Michael Buesch <mb@bu3sch.de>
Subject: Re: [PATCH] mac80211: better rate control algorithm selection
Date: Wed, 2 Jan 2008 08:45:32 +0000 [thread overview]
Message-ID: <20080102084532.GA17960@infradead.org> (raw)
In-Reply-To: <1199263275.4172.60.camel@johannes.berg>
On Wed, Jan 02, 2008 at 09:41:15AM +0100, Johannes Berg wrote:
>
> > Why don't we just build the rate control algorithms entirely separate
> > useing obj-$(FOO) ? If they're modular that lets them be their own
> > module, and if they're built-in they'll still go into built-in.o.
>
> Yeah. Except that they can't be built-in if mac80211 isn't, and we've
> repeatedly had users f' up their installations and bitterly report to us
> that mac80211 doesn't work because no rate control algorithm is
> available so we wanted to force having one built into mac80211.ko unless
> specifically turned off (only with EMBEDDED).
Building an algorithm optionally into mac80211 seems rather odd. In
case mac80211 the algorithms should be their own modules and you should
use request_module to make sure at least one is loaded. Or if you
really want to make sure one is alway avaiabable always build the
simplest one directly and unconditionally into mac80211.ko.
>
> johannes
---end quoted text---
next prev parent reply other threads:[~2008-01-02 8:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-21 16:09 [PATCH] mac80211: better rate control algorithm selection Johannes Berg
2007-12-21 20:00 ` Stefano Brivio
2007-12-21 20:43 ` Johannes Berg
2007-12-21 20:57 ` Stefano Brivio
2007-12-21 21:15 ` Johannes Berg
2007-12-21 21:43 ` [PATCH v2] " Johannes Berg
2007-12-21 22:26 ` Stefano Brivio
2007-12-30 23:11 ` [PATCH] " Sam Ravnborg
2007-12-31 7:45 ` Christoph Hellwig
2008-01-02 8:41 ` Johannes Berg
2008-01-02 8:45 ` Christoph Hellwig [this message]
2008-01-02 8:52 ` Johannes Berg
2008-01-02 15:23 ` Michael Buesch
2008-01-02 15:27 ` Johannes Berg
2008-01-02 15:29 ` Michael Buesch
2008-01-02 23:05 ` Stefano Brivio
2008-01-02 14:04 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080102084532.GA17960@infradead.org \
--to=hch@infradead.org \
--cc=flamingice@sourmilk.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=sam@ravnborg.org \
--cc=stefano.brivio@polimi.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).