linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefano Brivio <stefano.brivio@polimi.it>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Michael Buesch <mb@bu3sch.de>,
	Christoph Hellwig <hch@infradead.org>,
	Sam Ravnborg <sam@ravnborg.org>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Michael Wu <flamingice@sourmilk.net>
Subject: Re: [PATCH] mac80211: better rate control algorithm selection
Date: Thu, 3 Jan 2008 00:05:41 +0100	[thread overview]
Message-ID: <20080103000541.38593206@morte> (raw)
In-Reply-To: <1199287652.4172.90.camel@johannes.berg>

On Wed, 02 Jan 2008 16:27:32 +0100
Johannes Berg <johannes@sipsolutions.net> wrote:

> > What about simply _not_ failing the initialization of mac80211, if no
> > rc algo is available? I mean, we can just use a fixed rate we get through
> > WEXT and stuff. Simply start at 1M on init in that case and stay at a fixed
> > 1M until the user sets a different fixed rate through WEXT.
> 
> Not sure. I think I'd prefer not to have all special cases all over, I'd
> much prefer a new rc80211_none or so then.

Agreed. But again, that should be built into mac80211, if we want to work
around issues caused by lack of module autoloading. And to me it looks like
'rc80211_none' implies yet another 'real' rate control algorithm.

I propose to just replace a few lines of code in mac80211 in order to look
for the lowest available rate and set it instead of failing. mac80211 should
[1] correctly deal with forced rates, so that would be everything we need.

[1] I know it doesn't right now. That should be fixed first anyway.


-- 
Ciao
Stefano

  parent reply	other threads:[~2008-01-02 23:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-21 16:09 [PATCH] mac80211: better rate control algorithm selection Johannes Berg
2007-12-21 20:00 ` Stefano Brivio
2007-12-21 20:43   ` Johannes Berg
2007-12-21 20:57     ` Stefano Brivio
2007-12-21 21:15       ` Johannes Berg
2007-12-21 21:43 ` [PATCH v2] " Johannes Berg
2007-12-21 22:26   ` Stefano Brivio
2007-12-30 23:11 ` [PATCH] " Sam Ravnborg
2007-12-31  7:45   ` Christoph Hellwig
2008-01-02  8:41     ` Johannes Berg
2008-01-02  8:45       ` Christoph Hellwig
2008-01-02  8:52         ` Johannes Berg
2008-01-02 15:23           ` Michael Buesch
2008-01-02 15:27             ` Johannes Berg
2008-01-02 15:29               ` Michael Buesch
2008-01-02 23:05               ` Stefano Brivio [this message]
2008-01-02 14:04   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080103000541.38593206@morte \
    --to=stefano.brivio@polimi.it \
    --cc=flamingice@sourmilk.net \
    --cc=hch@infradead.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mb@bu3sch.de \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).