Re: [PATCH] mac80211: Initialize vif pointer

[Ivo van Doorn <ivdoorn@gmail.com>]

On Sunday 13 January 2008, Johannes Berg wrote:
> 
> On Sun, 2008-01-13 at 14:02 +0100, Ivo van Doorn wrote:
> > Before calling update_beacon() mac80211 must
> > initialize the control.vif pointer so it can
> > be used by the driver to determine which
> > interface is trying to send the beacon.
> 
> Good catch, thanks Ivo. I'd prefer if it was set a few lines lower
> though where all the other control members are initialised. Mind
> respinning? Feel free to add

Not a problem, I just discovered a second location where the
vif is uninitialized for beaconing so I was preparing a second patch already. :)

> Acked-by: Johannes Berg <johannes@sipsolutions.net>
> 
> 
> > Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
> 
> 
> > ---
> > 
> > diff --git a/net/mac80211/ieee80211_sta.c b/net/mac80211/ieee80211_sta.c
> > index 4f5d5c6..8a35fed 100644
> > --- a/net/mac80211/ieee80211_sta.c
> > +++ b/net/mac80211/ieee80211_sta.c
> > @@ -2536,6 +2536,7 @@ static int ieee80211_sta_join_ibss(struct net_device *dev,
> >  		}
> >  
> >  		memset(&control, 0, sizeof(control));
> > +		control.vif = &sdata->vif;
> >  		rate_control_get_rate(dev, local->oper_hw_mode, skb, &ratesel);
> >  		if (!ratesel.rate) {
> >  			printk(KERN_DEBUG "%s: Failed to determine TX rate "
> > -
> > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
>