* [PATCH] rt2x00: remove unused variable
@ 2008-01-13 18:48 Stefano Brivio
2008-01-13 19:14 ` [Rt2400-devel] " Ivo van Doorn
0 siblings, 1 reply; 9+ messages in thread
From: Stefano Brivio @ 2008-01-13 18:48 UTC (permalink / raw)
To: John W. Linville, rt2400-devel; +Cc: linux-wireless
Remove an unused variable that caused a warning while building. Please note
that the pipe obtained there isn't used anywhere else.
Signed-off-by: Stefano Brivio <stefano.brivio@polimi.it>
---
Index: wireless-2.6/drivers/net/wireless/rt2x00/rt2x00usb.c
===================================================================
--- wireless-2.6.orig/drivers/net/wireless/rt2x00/rt2x00usb.c
+++ wireless-2.6/drivers/net/wireless/rt2x00/rt2x00usb.c
@@ -176,7 +176,6 @@ int rt2x00usb_write_tx_data(struct rt2x0
struct usb_device *usb_dev =
interface_to_usbdev(rt2x00dev_usb(rt2x00dev));
struct data_entry *entry = rt2x00_get_data_entry(ring);
- int pipe = usb_sndbulkpipe(usb_dev, 1);
struct skb_desc *desc;
u32 length;
--
Ciao
Stefano
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Rt2400-devel] [PATCH] rt2x00: remove unused variable
2008-01-13 18:48 [PATCH] rt2x00: remove unused variable Stefano Brivio
@ 2008-01-13 19:14 ` Ivo van Doorn
2008-01-13 19:16 ` Stefano Brivio
2008-01-13 19:31 ` Michael Buesch
0 siblings, 2 replies; 9+ messages in thread
From: Ivo van Doorn @ 2008-01-13 19:14 UTC (permalink / raw)
To: rt2400-devel; +Cc: Stefano Brivio, John W. Linville, linux-wireless
Hi,
> Remove an unused variable that caused a warning while building. Please note
> that the pipe obtained there isn't used anywhere else.
This patch is in wireless-2.6 already...
Ivo
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Rt2400-devel] [PATCH] rt2x00: remove unused variable
2008-01-13 19:14 ` [Rt2400-devel] " Ivo van Doorn
@ 2008-01-13 19:16 ` Stefano Brivio
2008-01-13 21:48 ` Ivo van Doorn
2008-01-13 19:31 ` Michael Buesch
1 sibling, 1 reply; 9+ messages in thread
From: Stefano Brivio @ 2008-01-13 19:16 UTC (permalink / raw)
To: Ivo van Doorn; +Cc: rt2400-devel, John W. Linville, linux-wireless
On Sun, 13 Jan 2008 20:14:53 +0100
Ivo van Doorn <ivdoorn@gmail.com> wrote:
> Hi,
>
> > Remove an unused variable that caused a warning while building. Please note
> > that the pipe obtained there isn't used anywhere else.
>
> This patch is in wireless-2.6 already...
Actually, I thought I already sent this patch, but couldn't find it
anywhere, neither in my outbox nor in git-log. Could you tell me what's the
related SHA commit? Thanks.
--
Ciao
Stefano
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Rt2400-devel] [PATCH] rt2x00: remove unused variable
2008-01-13 19:16 ` Stefano Brivio
@ 2008-01-13 21:48 ` Ivo van Doorn
2008-01-13 22:11 ` Michael Buesch
0 siblings, 1 reply; 9+ messages in thread
From: Ivo van Doorn @ 2008-01-13 21:48 UTC (permalink / raw)
To: Stefano Brivio; +Cc: rt2400-devel, John W. Linville, linux-wireless
Hi.
> > > Remove an unused variable that caused a warning while building. Please note
> > > that the pipe obtained there isn't used anywhere else.
> >
> > This patch is in wireless-2.6 already...
>
> Actually, I thought I already sent this patch, but couldn't find it
> anywhere, neither in my outbox nor in git-log. Could you tell me what's the
> related SHA commit? Thanks.
This is in my rt2x00.git log. It is signed off by John and not by me,
so that means it didn't go through rt2x00.git to get into the wireless tree.
I have merged the patch into rt2x00.git during my last clone from wireless...
commit 01b0258008a73648245dcbc628ff948878c428e0
Author: Stefano Brivio <stefano.brivio@polimi.it>
Date: Wed Dec 19 01:43:33 2007 +0100
rt2x00: remove unused variable
Remove an unused variable. Note that the pipe obtained there isn't used as
well.
Signed-off-by: Stefano Brivio <stefano.brivio@polimi.it>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [Rt2400-devel] [PATCH] rt2x00: remove unused variable
2008-01-13 21:48 ` Ivo van Doorn
@ 2008-01-13 22:11 ` Michael Buesch
2008-01-13 22:30 ` Ivo van Doorn
0 siblings, 1 reply; 9+ messages in thread
From: Michael Buesch @ 2008-01-13 22:11 UTC (permalink / raw)
To: Ivo van Doorn
Cc: Stefano Brivio, rt2400-devel, John W. Linville, linux-wireless
On Sunday 13 January 2008 22:48:47 Ivo van Doorn wrote:
> Hi.
>
> > > > Remove an unused variable that caused a warning while building. Please note
> > > > that the pipe obtained there isn't used anywhere else.
> > >
> > > This patch is in wireless-2.6 already...
> >
> > Actually, I thought I already sent this patch, but couldn't find it
> > anywhere, neither in my outbox nor in git-log. Could you tell me what's the
> > related SHA commit? Thanks.
>
> This is in my rt2x00.git log. It is signed off by John and not by me,
> so that means it didn't go through rt2x00.git to get into the wireless tree.
> I have merged the patch into rt2x00.git during my last clone from wireless...
>
> commit 01b0258008a73648245dcbc628ff948878c428e0
> Author: Stefano Brivio <stefano.brivio@polimi.it>
> Date: Wed Dec 19 01:43:33 2007 +0100
>
> rt2x00: remove unused variable
>
> Remove an unused variable. Note that the pipe obtained there isn't used as
> well.
>
> Signed-off-by: Stefano Brivio <stefano.brivio@polimi.it>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
I cannot find this commit in wireless-2.6
--
Greetings Michael.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Rt2400-devel] [PATCH] rt2x00: remove unused variable
2008-01-13 22:11 ` Michael Buesch
@ 2008-01-13 22:30 ` Ivo van Doorn
2008-01-15 18:13 ` John W. Linville
0 siblings, 1 reply; 9+ messages in thread
From: Ivo van Doorn @ 2008-01-13 22:30 UTC (permalink / raw)
To: Michael Buesch, John W. Linville
Cc: Stefano Brivio, rt2400-devel, linux-wireless
On Sunday 13 January 2008, Michael Buesch wrote:
> On Sunday 13 January 2008 22:48:47 Ivo van Doorn wrote:
> > Hi.
> >
> > > > > Remove an unused variable that caused a warning while building. Please note
> > > > > that the pipe obtained there isn't used anywhere else.
> > > >
> > > > This patch is in wireless-2.6 already...
> > >
> > > Actually, I thought I already sent this patch, but couldn't find it
> > > anywhere, neither in my outbox nor in git-log. Could you tell me what's the
> > > related SHA commit? Thanks.
> >
> > This is in my rt2x00.git log. It is signed off by John and not by me,
> > so that means it didn't go through rt2x00.git to get into the wireless tree.
> > I have merged the patch into rt2x00.git during my last clone from wireless...
> >
> > commit 01b0258008a73648245dcbc628ff948878c428e0
> > Author: Stefano Brivio <stefano.brivio@polimi.it>
> > Date: Wed Dec 19 01:43:33 2007 +0100
> >
> > rt2x00: remove unused variable
> >
> > Remove an unused variable. Note that the pipe obtained there isn't used as
> > well.
> >
> > Signed-off-by: Stefano Brivio <stefano.brivio@polimi.it>
> > Signed-off-by: John W. Linville <linville@tuxdriver.com>
>
> I cannot find this commit in wireless-2.6
Strange, git is pulling tricks of some kind. I have the patch in 3 branches of rt2x00.git,
master, wireless and upstream. This means it was pulled in from the everything branch
on wireless-2.6. So apparently during the rebasing in wireless the patch has disappeared
or something. :S
John, can you apply the patch to wireless? Otherwise I'll apply it to rt2x00.git later
this week when I rebase everything against the latest wireless git repository (which
would remove the old patch from my tree, so I can apply it without conflicts).
Ivo
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Rt2400-devel] [PATCH] rt2x00: remove unused variable
2008-01-13 22:30 ` Ivo van Doorn
@ 2008-01-15 18:13 ` John W. Linville
0 siblings, 0 replies; 9+ messages in thread
From: John W. Linville @ 2008-01-15 18:13 UTC (permalink / raw)
To: Ivo van Doorn
Cc: Michael Buesch, Stefano Brivio, rt2400-devel, linux-wireless
On Sun, Jan 13, 2008 at 11:30:39PM +0100, Ivo van Doorn wrote:
> Strange, git is pulling tricks of some kind. I have the patch in 3 branches of rt2x00.git,
> master, wireless and upstream. This means it was pulled in from the everything branch
> on wireless-2.6. So apparently during the rebasing in wireless the patch has disappeared
> or something. :S
Yes, that is likely what happened. I'll take care of it.
John
--
John W. Linville
linville@tuxdriver.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Rt2400-devel] [PATCH] rt2x00: remove unused variable
2008-01-13 19:14 ` [Rt2400-devel] " Ivo van Doorn
2008-01-13 19:16 ` Stefano Brivio
@ 2008-01-13 19:31 ` Michael Buesch
1 sibling, 0 replies; 9+ messages in thread
From: Michael Buesch @ 2008-01-13 19:31 UTC (permalink / raw)
To: Ivo van Doorn
Cc: rt2400-devel, Stefano Brivio, John W. Linville, linux-wireless
On Sunday 13 January 2008 20:14:53 Ivo van Doorn wrote:
> Hi,
>
> > Remove an unused variable that caused a warning while building. Please note
> > that the pipe obtained there isn't used anywhere else.
>
> This patch is in wireless-2.6 already...
No it is not in wireless-2.6.
--
Greetings Michael.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] rt2x00: remove unused variable
@ 2007-12-19 0:43 Stefano Brivio
0 siblings, 0 replies; 9+ messages in thread
From: Stefano Brivio @ 2007-12-19 0:43 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless, rt2400-devel
Remove an unused variable. Note that the pipe obtained there isn't used as
well.
Signed-off-by: Stefano Brivio <stefano.brivio@polimi.it>
---
Index: wireless-2.6/drivers/net/wireless/rt2x00/rt2x00usb.c
===================================================================
--- wireless-2.6.orig/drivers/net/wireless/rt2x00/rt2x00usb.c
+++ wireless-2.6/drivers/net/wireless/rt2x00/rt2x00usb.c
@@ -176,7 +176,6 @@ int rt2x00usb_write_tx_data(struct rt2x0
struct usb_device *usb_dev =
interface_to_usbdev(rt2x00dev_usb(rt2x00dev));
struct data_entry *entry = rt2x00_get_data_entry(ring);
- int pipe = usb_sndbulkpipe(usb_dev, 1);
struct skb_desc *desc;
u32 length;
--
Ciao
Stefano
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2008-01-15 18:24 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-13 18:48 [PATCH] rt2x00: remove unused variable Stefano Brivio
2008-01-13 19:14 ` [Rt2400-devel] " Ivo van Doorn
2008-01-13 19:16 ` Stefano Brivio
2008-01-13 21:48 ` Ivo van Doorn
2008-01-13 22:11 ` Michael Buesch
2008-01-13 22:30 ` Ivo van Doorn
2008-01-15 18:13 ` John W. Linville
2008-01-13 19:31 ` Michael Buesch
-- strict thread matches above, loose matches on Subject: below --
2007-12-19 0:43 Stefano Brivio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).