From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp115.sbc.mail.sp1.yahoo.com ([69.147.64.88]:36401 "HELO smtp115.sbc.mail.sp1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754352AbYAYBUW (ORCPT ); Thu, 24 Jan 2008 20:20:22 -0500 From: David Brownell To: Jussi Kivilinna Subject: Re: [PATCH 06/14] [usbnet] Use wlan device name for RNDIS wireless devices Date: Thu, 24 Jan 2008 16:56:40 -0800 Cc: linux-wireless@vger.kernel.org, bjd@jooz.net, netdev@vger.kernel.org References: <20080120001415.25718.1762.stgit@fate.lan> In-Reply-To: <20080120001415.25718.1762.stgit@fate.lan> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Message-Id: <200801241656.40667.david-b@pacbell.net> (sfid-20080125_012045_245802_9F3C1736) Sender: linux-wireless-owner@vger.kernel.org List-ID: On Saturday 19 January 2008, Jussi Kivilinna wrote: > Use wlan device name for RNDIS wireless devices. > > Signed-off-by: Jussi Kivilinna > Signed-off-by: Bjorge Dijkstra Acked-by: David Brownell > --- > > drivers/net/usb/usbnet.c | 3 +++ > drivers/net/usb/usbnet.h | 2 ++ > 2 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c > index 8ed1fc5..a2a2d5e 100644 > --- a/drivers/net/usb/usbnet.c > +++ b/drivers/net/usb/usbnet.c > @@ -1204,6 +1204,9 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod) > if ((dev->driver_info->flags & FLAG_ETHER) != 0 > && (net->dev_addr [0] & 0x02) == 0) > strcpy (net->name, "eth%d"); > + /* WLAN devices should always be named "wlan%d" */ > + if ((dev->driver_info->flags & FLAG_WLAN) != 0) > + strcpy(net->name, "wlan%d"); > > /* maybe the remote can't receive an Ethernet MTU */ > if (net->mtu > (dev->hard_mtu - net->hard_header_len)) > diff --git a/drivers/net/usb/usbnet.h b/drivers/net/usb/usbnet.h > index 1fae434..29ab92e 100644 > --- a/drivers/net/usb/usbnet.h > +++ b/drivers/net/usb/usbnet.h > @@ -87,6 +87,8 @@ struct driver_info { > #define FLAG_ETHER 0x0020 /* maybe use "eth%d" names */ > > #define FLAG_FRAMING_AX 0x0040 /* AX88772/178 packets */ > +#define FLAG_WLAN 0x0080 /* use "wlan%d" names */ > + > > /* init device ... can sleep, or cause probe() failure */ > int (*bind)(struct usbnet *, struct usb_interface *); >