Re: [PATCH 00/14] RFC: Driver for Wireless RNDIS USB devices.

["John W. Linville" <linville@tuxdriver.com>]

On Wed, Jan 23, 2008 at 07:44:46PM +0200, Jussi Kivilinna wrote:
> On Wed, 2008-01-23 at 09:52 -0500, John W. Linville wrote:
> > I would like to have this driver soon, and FWIW I just put it in the
> > Fedora Rawhide kernel last night.
> > 
> > However, I find that it does not seem to associate with WEP networks
> > on my USR5421.  I haven't had a chance to try it on open or WPA
> > networks, nor have I had a chance to debug it.  It does scan and see
> > the networks.
> > 
> > Have you tested the driver as posted?  What device(s) are you using?
> > Have you used it on encrypted networks?
> 
> I guess I should start testing more if I'm going to be maintainer,
> you're right WEP doesn't work. Unencrypted and WPA/WPA2 networks do work
> for me but not WEP. Ad-Hoc and hidden WPA networks do not work either. I
> have Buffalo WLI-U2-KG125S which should have same hardware/firmware as
> USR5421.

Overall this looks fine to me for initial merge.  I have a couple
of comments:

	-- I'm not too excited about the "Ndis_802_*" naming scheme for
	data structures, although I know you copied it from elsewhere.
	I'd like to see it changed, but I don't consider that a
	merge blocker.

	-- I foresee this driver surviving a conversion to use the
	new cfg80211 configuraiton API.  So the "rndis_wext" name may
	not be the best long-term choice.  I might suggest something
	like "rndis_wlan".  I don't see why we couldn't change that
	post-merge, although I would prefer to do that before the
	final 2.6.25 release.

So, I intend to push this upstream for 2.6.25.  Please consider making
the changes cited above, especially the name change.

Thanks,

John
-- 
John W. Linville
linville@tuxdriver.com