From: Stefano Brivio <stefano.brivio@polimi.it>
To: "John W. Linville" <linville@tuxdriver.com>,
Larry Finger <larry.finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org, Mattias Nissler <mattias.nissler@gmx.de>
Subject: [PATCH 2/2] rc80211-pid: add sanity check
Date: Sat, 26 Jan 2008 04:05:34 +0100 [thread overview]
Message-ID: <20080126040534.005e6736@morte> (raw)
From: Larry Finger <larry.finger@lwfinger.net>
Add a sanity check in rate_control_pid_adjust_rate(). Thanks to Larry Finger
for suggesting this and reporting a related bug.
Signed-off-by: Stefano Brivio <stefano.brivio@polimi.it>
NOT-Signed-off-by: Larry Finger <larry.finger@lwfinger.net>
---
Index: wireless-2.6/net/mac80211/rc80211_pid_algo.c
===================================================================
--- wireless-2.6.orig/net/mac80211/rc80211_pid_algo.c
+++ wireless-2.6/net/mac80211/rc80211_pid_algo.c
@@ -128,6 +128,11 @@ static void rate_control_pid_adjust_rate
}
newidx += back;
+
+ if (newidx < 0 || newidx >= sband->n_bitrates) {
+ WARN_ON(1);
+ break;
+ }
}
#ifdef CONFIG_MAC80211_DEBUGFS
--
Ciao
Stefano
next reply other threads:[~2008-01-26 3:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-26 3:05 Stefano Brivio [this message]
2008-01-26 3:20 ` [PATCH 2/2] rc80211-pid: add sanity check Larry Finger
2008-01-26 11:19 ` Michael Buesch
2008-01-26 19:40 ` Lars
2008-01-27 12:42 ` Stefano Brivio
2008-01-27 13:22 ` mac80211 refcounting bug was: " Stefano Brivio
2008-01-27 14:32 ` Stefano Brivio
2008-01-27 13:53 ` Lars Ericsson
2008-01-27 16:56 ` Larry Finger
2008-01-27 18:51 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080126040534.005e6736@morte \
--to=stefano.brivio@polimi.it \
--cc=larry.finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mattias.nissler@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).