From: Andi Kleen <andi@firstfloor.org>
To: jirislaby@gmail.com, linux-wireless@vger.kernel.org,
ath5k-devel@lists.ath5k.org, linville@tuxdriver.com
Subject: ath5k Kconfig / lspci / pci_device_id consistency
Date: Wed, 30 Jan 2008 10:07:03 +0100 [thread overview]
Message-ID: <20080130090703.GA9218@basil.nowhere.org> (raw)
Hallo,
I was pleasantly surprised at first that ath5k has finally made it into mainline.
That is because my laptop has an atheros chipset and in tree support makes
things much easier for me.
Then I noticed that the chips it claims to support in Kconfig
Currently the following chip versions are supported:
MAC: AR5211 AR5212
PHY: RF5111/2111 RF5112/2112 RF5413/2413
did not include the chip on my laptop; an AR5006X according to lspci.
But when I actually look at the driver's pci_device_id table it seems
to be supported. I have
08:0a.0 Class 0200: 168c:001b (rev 01)
which seems to match ath5k/base.c
{ PCI_VDEVICE(ATHEROS, 0x001b), .driver_data = AR5K_AR5212 }, /* 5413 Eagle */
But the name in the comment does not agree with what lspci reports:
08:0a.0 Ethernet controller: Atheros Communications, Inc. AR5006X 802.11abg NIC (rev 01)
So who has the correct name? The comments in the driver or lspci? Or are there
valid aliases? And can Kconfig be fixed up to include all chips supported by
the driver, preferably with the same names as lspci reports please?
I have not actually tested yet if it really works.
Thanks,
-Andi
reply other threads:[~2008-01-30 9:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080130090703.GA9218@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=ath5k-devel@lists.ath5k.org \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).