From: Ivo van Doorn <ivdoorn@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wireless: Fix WARN_ON() with ieee802.11b
Date: Sun, 3 Feb 2008 12:21:27 +0100 [thread overview]
Message-ID: <200802031221.28432.IvDoorn@gmail.com> (raw)
In-Reply-To: <1202034082.4188.116.camel@johannes.berg>
On Sunday 03 February 2008, Johannes Berg wrote:
>
> > When the driver registers a IEEE80211_BAND_2GHZ band,
> > it can either be 802.11b or 802.11g. But when 802.11b rates
> > are registered "want" will be 3 (since 4 rates are being registered,
> > and each of those 4 rates will decrease "want").
>
> Huh, yeah, you're right, this is a thinko.
>
> > - WARN_ON(want != 0 && want != 6);
> > + WARN_ON(want != 0 && want != 3 && want != 6);
>
> However, I think it should just be
>
> WARN_ON(want != 0 && want != 3);
>
> 6 just doesn't make sense, does it?
Well from your code it seemed that you only made 1Mbit mandatory for
802.11b. So if you want to make all b rates mandatory then the 6 check should
indeed be removed.
But shouldn't the 2Mbit, 5.5Mbit and 11Mbit set as IEEE80211_RATE_MANDATORY_B
as well?
Ivo
next prev parent reply other threads:[~2008-02-03 11:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-02 22:53 [PATCH] wireless: Fix WARN_ON() with ieee802.11b Ivo van Doorn
2008-02-03 1:39 ` Nick Kossifidis
2008-02-03 10:21 ` Johannes Berg
2008-02-03 11:21 ` Ivo van Doorn [this message]
2008-02-03 12:38 ` Johannes Berg
2008-02-03 12:42 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802031221.28432.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).