linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] wireless/ath5k: renamed to ath5k_pci_driver to fix Section mismatch warnings
@ 2008-02-02  2:55 Denis Cheng
  2008-02-02 16:26 ` Nick Kossifidis
  2008-02-04 19:50 ` John W. Linville
  0 siblings, 2 replies; 3+ messages in thread
From: Denis Cheng @ 2008-02-02  2:55 UTC (permalink / raw)
  To: Jiri Slaby, Nick Kossifidis, Luis R. Rodriguez
  Cc: linux-wireless, ath5k-devel, linux-kernel

the struct pci_driver refered ath5k_pci_id_table which in __devinit section,
the sparse tool suggest this renamed to "*driver", kills mismatch warnings.

Signed-off-by: Denis Cheng <crquan@gmail.com>
---
 drivers/net/wireless/ath5k/base.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c
index d6599d2..ddc8714 100644
--- a/drivers/net/wireless/ath5k/base.c
+++ b/drivers/net/wireless/ath5k/base.c
@@ -153,7 +153,7 @@ static int		ath5k_pci_resume(struct pci_dev *pdev);
 #define ath5k_pci_resume NULL
 #endif /* CONFIG_PM */
 
-static struct pci_driver ath5k_pci_drv_id = {
+static struct pci_driver ath5k_pci_driver = {
 	.name		= "ath5k_pci",
 	.id_table	= ath5k_pci_id_table,
 	.probe		= ath5k_pci_probe,
@@ -329,7 +329,7 @@ init_ath5k_pci(void)
 
 	ath5k_debug_init();
 
-	ret = pci_register_driver(&ath5k_pci_drv_id);
+	ret = pci_register_driver(&ath5k_pci_driver);
 	if (ret) {
 		printk(KERN_ERR "ath5k_pci: can't register pci driver\n");
 		return ret;
@@ -341,7 +341,7 @@ init_ath5k_pci(void)
 static void __exit
 exit_ath5k_pci(void)
 {
-	pci_unregister_driver(&ath5k_pci_drv_id);
+	pci_unregister_driver(&ath5k_pci_driver);
 
 	ath5k_debug_finish();
 }
-- 
1.5.3.8


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] wireless/ath5k: renamed to ath5k_pci_driver to fix Section mismatch warnings
  2008-02-02  2:55 [PATCH] wireless/ath5k: renamed to ath5k_pci_driver to fix Section mismatch warnings Denis Cheng
@ 2008-02-02 16:26 ` Nick Kossifidis
  2008-02-04 19:50 ` John W. Linville
  1 sibling, 0 replies; 3+ messages in thread
From: Nick Kossifidis @ 2008-02-02 16:26 UTC (permalink / raw)
  To: Denis Cheng
  Cc: Jiri Slaby, Luis R. Rodriguez, linux-wireless, ath5k-devel,
	linux-kernel

2008/2/2, Denis Cheng <crquan@gmail.com>:
> the struct pci_driver refered ath5k_pci_id_table which in __devinit section,
> the sparse tool suggest this renamed to "*driver", kills mismatch warnings.
>
> Signed-off-by: Denis Cheng <crquan@gmail.com>
> ---
>  drivers/net/wireless/ath5k/base.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c
> index d6599d2..ddc8714 100644
> --- a/drivers/net/wireless/ath5k/base.c
> +++ b/drivers/net/wireless/ath5k/base.c
> @@ -153,7 +153,7 @@ static int          ath5k_pci_resume(struct pci_dev *pdev);
>  #define ath5k_pci_resume NULL
>  #endif /* CONFIG_PM */
>
> -static struct pci_driver ath5k_pci_drv_id = {
> +static struct pci_driver ath5k_pci_driver = {
>         .name           = "ath5k_pci",
>         .id_table       = ath5k_pci_id_table,
>         .probe          = ath5k_pci_probe,
> @@ -329,7 +329,7 @@ init_ath5k_pci(void)
>
>         ath5k_debug_init();
>
> -       ret = pci_register_driver(&ath5k_pci_drv_id);
> +       ret = pci_register_driver(&ath5k_pci_driver);
>         if (ret) {
>                 printk(KERN_ERR "ath5k_pci: can't register pci driver\n");
>                 return ret;
> @@ -341,7 +341,7 @@ init_ath5k_pci(void)
>  static void __exit
>  exit_ath5k_pci(void)
>  {
> -       pci_unregister_driver(&ath5k_pci_drv_id);
> +       pci_unregister_driver(&ath5k_pci_driver);
>
>         ath5k_debug_finish();
>  }
> --
> 1.5.3.8
>
>

Thanx ;-)

Acked-by: Nick Kossifidis <mickflemm@gmail.com>

-- 
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] wireless/ath5k: renamed to ath5k_pci_driver to fix Section mismatch warnings
  2008-02-02  2:55 [PATCH] wireless/ath5k: renamed to ath5k_pci_driver to fix Section mismatch warnings Denis Cheng
  2008-02-02 16:26 ` Nick Kossifidis
@ 2008-02-04 19:50 ` John W. Linville
  1 sibling, 0 replies; 3+ messages in thread
From: John W. Linville @ 2008-02-04 19:50 UTC (permalink / raw)
  To: Denis Cheng
  Cc: Jiri Slaby, Nick Kossifidis, Luis R. Rodriguez, linux-wireless,
	ath5k-devel, linux-kernel

On Sat, Feb 02, 2008 at 10:55:10AM +0800, Denis Cheng wrote:
> the struct pci_driver refered ath5k_pci_id_table which in __devinit section,
> the sparse tool suggest this renamed to "*driver", kills mismatch warnings.
> 
> Signed-off-by: Denis Cheng <crquan@gmail.com>

Sorry, I beat you to it on Friday... :-)

John
-- 
John W. Linville
linville@tuxdriver.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-02-04 20:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-02  2:55 [PATCH] wireless/ath5k: renamed to ath5k_pci_driver to fix Section mismatch warnings Denis Cheng
2008-02-02 16:26 ` Nick Kossifidis
2008-02-04 19:50 ` John W. Linville

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).