* [PATCH] rt2x00: Add new USB ID to rt2500usb
@ 2008-02-10 10:21 Ivo van Doorn
2008-02-10 10:31 ` Michael Buesch
0 siblings, 1 reply; 7+ messages in thread
From: Ivo van Doorn @ 2008-02-10 10:21 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless
Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
---
John, please send this patch to the 2.6.24/2.6.25 stable trees.
It is already present in the wireless-2.6 tree queued for 2.6.26.
drivers/net/wireless/rt2x00/rt2500usb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2500usb.c b/drivers/net/wireless/rt2x00/rt2500usb.c
index cba7f57..c4a6ab4 100644
--- a/drivers/net/wireless/rt2x00/rt2500usb.c
+++ b/drivers/net/wireless/rt2x00/rt2500usb.c
@@ -1871,11 +1871,11 @@ static struct usb_device_id rt2500usb_device_table[] = {
/* Hercules */
{ USB_DEVICE(0x06f8, 0xe000), USB_DEVICE_DATA(&rt2500usb_ops) },
/* Melco */
+ { USB_DEVICE(0x0411, 0x005e), USB_DEVICE_DATA(&rt2500usb_ops) },
{ USB_DEVICE(0x0411, 0x0066), USB_DEVICE_DATA(&rt2500usb_ops) },
{ USB_DEVICE(0x0411, 0x0067), USB_DEVICE_DATA(&rt2500usb_ops) },
{ USB_DEVICE(0x0411, 0x008b), USB_DEVICE_DATA(&rt2500usb_ops) },
{ USB_DEVICE(0x0411, 0x0097), USB_DEVICE_DATA(&rt2500usb_ops) },
-
/* MSI */
{ USB_DEVICE(0x0db0, 0x6861), USB_DEVICE_DATA(&rt2500usb_ops) },
{ USB_DEVICE(0x0db0, 0x6865), USB_DEVICE_DATA(&rt2500usb_ops) },
--
1.5.3.8
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] rt2x00: Add new USB ID to rt2500usb
2008-02-10 10:21 [PATCH] rt2x00: Add new USB ID to rt2500usb Ivo van Doorn
@ 2008-02-10 10:31 ` Michael Buesch
2008-02-10 10:36 ` Ivo van Doorn
2008-02-10 12:22 ` Luis Correia
0 siblings, 2 replies; 7+ messages in thread
From: Michael Buesch @ 2008-02-10 10:31 UTC (permalink / raw)
To: Ivo van Doorn; +Cc: John W. Linville, linux-wireless
On Sunday 10 February 2008 11:21:57 Ivo van Doorn wrote:
>
> Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
> ---
> John, please send this patch to the 2.6.24/2.6.25 stable trees.
> It is already present in the wireless-2.6 tree queued for 2.6.26.
>
> drivers/net/wireless/rt2x00/rt2500usb.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2500usb.c b/drivers/net/wireless/rt2x00/rt2500usb.c
> index cba7f57..c4a6ab4 100644
> --- a/drivers/net/wireless/rt2x00/rt2500usb.c
> +++ b/drivers/net/wireless/rt2x00/rt2500usb.c
> @@ -1871,11 +1871,11 @@ static struct usb_device_id rt2500usb_device_table[] = {
> /* Hercules */
> { USB_DEVICE(0x06f8, 0xe000), USB_DEVICE_DATA(&rt2500usb_ops) },
> /* Melco */
> + { USB_DEVICE(0x0411, 0x005e), USB_DEVICE_DATA(&rt2500usb_ops) },
> { USB_DEVICE(0x0411, 0x0066), USB_DEVICE_DATA(&rt2500usb_ops) },
> { USB_DEVICE(0x0411, 0x0067), USB_DEVICE_DATA(&rt2500usb_ops) },
> { USB_DEVICE(0x0411, 0x008b), USB_DEVICE_DATA(&rt2500usb_ops) },
> { USB_DEVICE(0x0411, 0x0097), USB_DEVICE_DATA(&rt2500usb_ops) },
> -
> /* MSI */
> { USB_DEVICE(0x0db0, 0x6861), USB_DEVICE_DATA(&rt2500usb_ops) },
> { USB_DEVICE(0x0db0, 0x6865), USB_DEVICE_DATA(&rt2500usb_ops) },
I'm unsure on how this is an actual _fix_ that we need in a stable kernel.
We always handled adding IDs as features.
--
Greetings Michael.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] rt2x00: Add new USB ID to rt2500usb
2008-02-10 10:31 ` Michael Buesch
@ 2008-02-10 10:36 ` Ivo van Doorn
2008-02-10 12:19 ` Michael Buesch
2008-02-10 12:22 ` Luis Correia
1 sibling, 1 reply; 7+ messages in thread
From: Ivo van Doorn @ 2008-02-10 10:36 UTC (permalink / raw)
To: Michael Buesch; +Cc: John W. Linville, linux-wireless
On Sunday 10 February 2008, Michael Buesch wrote:
> On Sunday 10 February 2008 11:21:57 Ivo van Doorn wrote:
> >
> > Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
> > ---
> > John, please send this patch to the 2.6.24/2.6.25 stable trees.
> > It is already present in the wireless-2.6 tree queued for 2.6.26.
> >
> > drivers/net/wireless/rt2x00/rt2500usb.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/net/wireless/rt2x00/rt2500usb.c b/drivers/net/wireless/rt2x00/rt2500usb.c
> > index cba7f57..c4a6ab4 100644
> > --- a/drivers/net/wireless/rt2x00/rt2500usb.c
> > +++ b/drivers/net/wireless/rt2x00/rt2500usb.c
> > @@ -1871,11 +1871,11 @@ static struct usb_device_id rt2500usb_device_table[] = {
> > /* Hercules */
> > { USB_DEVICE(0x06f8, 0xe000), USB_DEVICE_DATA(&rt2500usb_ops) },
> > /* Melco */
> > + { USB_DEVICE(0x0411, 0x005e), USB_DEVICE_DATA(&rt2500usb_ops) },
> > { USB_DEVICE(0x0411, 0x0066), USB_DEVICE_DATA(&rt2500usb_ops) },
> > { USB_DEVICE(0x0411, 0x0067), USB_DEVICE_DATA(&rt2500usb_ops) },
> > { USB_DEVICE(0x0411, 0x008b), USB_DEVICE_DATA(&rt2500usb_ops) },
> > { USB_DEVICE(0x0411, 0x0097), USB_DEVICE_DATA(&rt2500usb_ops) },
> > -
> > /* MSI */
> > { USB_DEVICE(0x0db0, 0x6861), USB_DEVICE_DATA(&rt2500usb_ops) },
> > { USB_DEVICE(0x0db0, 0x6865), USB_DEVICE_DATA(&rt2500usb_ops) },
>
> I'm unsure on how this is an actual _fix_ that we need in a stable kernel.
> We always handled adding IDs as features.
Ok, the user has to wait untill 2.6.26 then.
Ivo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] rt2x00: Add new USB ID to rt2500usb
2008-02-10 10:36 ` Ivo van Doorn
@ 2008-02-10 12:19 ` Michael Buesch
2008-02-10 12:33 ` Ivo van Doorn
0 siblings, 1 reply; 7+ messages in thread
From: Michael Buesch @ 2008-02-10 12:19 UTC (permalink / raw)
To: Ivo van Doorn; +Cc: John W. Linville, linux-wireless
On Sunday 10 February 2008 11:36:28 Ivo van Doorn wrote:
> On Sunday 10 February 2008, Michael Buesch wrote:
> > On Sunday 10 February 2008 11:21:57 Ivo van Doorn wrote:
> > >
> > > Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
> > > ---
> > > John, please send this patch to the 2.6.24/2.6.25 stable trees.
> > > It is already present in the wireless-2.6 tree queued for 2.6.26.
> > >
> > > drivers/net/wireless/rt2x00/rt2500usb.c | 2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/drivers/net/wireless/rt2x00/rt2500usb.c b/drivers/net/wireless/rt2x00/rt2500usb.c
> > > index cba7f57..c4a6ab4 100644
> > > --- a/drivers/net/wireless/rt2x00/rt2500usb.c
> > > +++ b/drivers/net/wireless/rt2x00/rt2500usb.c
> > > @@ -1871,11 +1871,11 @@ static struct usb_device_id rt2500usb_device_table[] = {
> > > /* Hercules */
> > > { USB_DEVICE(0x06f8, 0xe000), USB_DEVICE_DATA(&rt2500usb_ops) },
> > > /* Melco */
> > > + { USB_DEVICE(0x0411, 0x005e), USB_DEVICE_DATA(&rt2500usb_ops) },
> > > { USB_DEVICE(0x0411, 0x0066), USB_DEVICE_DATA(&rt2500usb_ops) },
> > > { USB_DEVICE(0x0411, 0x0067), USB_DEVICE_DATA(&rt2500usb_ops) },
> > > { USB_DEVICE(0x0411, 0x008b), USB_DEVICE_DATA(&rt2500usb_ops) },
> > > { USB_DEVICE(0x0411, 0x0097), USB_DEVICE_DATA(&rt2500usb_ops) },
> > > -
> > > /* MSI */
> > > { USB_DEVICE(0x0db0, 0x6861), USB_DEVICE_DATA(&rt2500usb_ops) },
> > > { USB_DEVICE(0x0db0, 0x6865), USB_DEVICE_DATA(&rt2500usb_ops) },
> >
> > I'm unsure on how this is an actual _fix_ that we need in a stable kernel.
> > We always handled adding IDs as features.
>
> Ok, the user has to wait untill 2.6.26 then.
Oh, it seems that -stable does actually accept such patches:
http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.23.y.git;a=commitdiff;h=2cf220bb5b30a922aebdd5841a7975e02a70ce59
http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.23.y.git;a=commitdiff;h=955ab48db7fb9e3d74dc770cca9aa6b194e53025
I wasn't aware of this, because we always had the rule of ID additions
being features, in the wireless team.
So well. I think John should probably make an official decision. :)
I would suggest the following: Unless there's another driver in
the tree that (partially) supports the device being added, adding the ID
can not cause a regression. So it's OK to add it, even in a stable cycle.
--
Greetings Michael.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] rt2x00: Add new USB ID to rt2500usb
2008-02-10 10:31 ` Michael Buesch
2008-02-10 10:36 ` Ivo van Doorn
@ 2008-02-10 12:22 ` Luis Correia
2008-02-12 16:05 ` John W. Linville
1 sibling, 1 reply; 7+ messages in thread
From: Luis Correia @ 2008-02-10 12:22 UTC (permalink / raw)
To: Michael Buesch; +Cc: Ivo van Doorn, John W. Linville, linux-wireless
On Sun, Feb 10, 2008 at 10:31 AM, Michael Buesch <mb@bu3sch.de> wrote:
> On Sunday 10 February 2008 11:21:57 Ivo van Doorn wrote:
> >
> > Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
> > ---
> > John, please send this patch to the 2.6.24/2.6.25 stable trees.
> > It is already present in the wireless-2.6 tree queued for 2.6.26.
> >
> > drivers/net/wireless/rt2x00/rt2500usb.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/net/wireless/rt2x00/rt2500usb.c b/drivers/net/wireless/rt2x00/rt2500usb.c
> > index cba7f57..c4a6ab4 100644
> > --- a/drivers/net/wireless/rt2x00/rt2500usb.c
> > +++ b/drivers/net/wireless/rt2x00/rt2500usb.c
> > @@ -1871,11 +1871,11 @@ static struct usb_device_id rt2500usb_device_table[] = {
> > /* Hercules */
> > { USB_DEVICE(0x06f8, 0xe000), USB_DEVICE_DATA(&rt2500usb_ops) },
> > /* Melco */
> > + { USB_DEVICE(0x0411, 0x005e), USB_DEVICE_DATA(&rt2500usb_ops) },
> > { USB_DEVICE(0x0411, 0x0066), USB_DEVICE_DATA(&rt2500usb_ops) },
> > { USB_DEVICE(0x0411, 0x0067), USB_DEVICE_DATA(&rt2500usb_ops) },
> > { USB_DEVICE(0x0411, 0x008b), USB_DEVICE_DATA(&rt2500usb_ops) },
> > { USB_DEVICE(0x0411, 0x0097), USB_DEVICE_DATA(&rt2500usb_ops) },
> > -
> > /* MSI */
> > { USB_DEVICE(0x0db0, 0x6861), USB_DEVICE_DATA(&rt2500usb_ops) },
> > { USB_DEVICE(0x0db0, 0x6865), USB_DEVICE_DATA(&rt2500usb_ops) },
>
> I'm unsure on how this is an actual _fix_ that we need in a stable kernel.
> We always handled adding IDs as features.
Please forgive me for stepping in this apparently already closed discussion.
Why is supporting a new USB ID considered a feature, when the users
are probably ok with it (it works) and no changes are added to the
code?
Luis Correia
rt2x00 project admin
>
> --
> Greetings Michael.
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] rt2x00: Add new USB ID to rt2500usb
2008-02-10 12:19 ` Michael Buesch
@ 2008-02-10 12:33 ` Ivo van Doorn
0 siblings, 0 replies; 7+ messages in thread
From: Ivo van Doorn @ 2008-02-10 12:33 UTC (permalink / raw)
To: Michael Buesch; +Cc: John W. Linville, linux-wireless
On Sunday 10 February 2008, Michael Buesch wrote:
> On Sunday 10 February 2008 11:36:28 Ivo van Doorn wrote:
> > On Sunday 10 February 2008, Michael Buesch wrote:
> > > On Sunday 10 February 2008 11:21:57 Ivo van Doorn wrote:
> > > >
> > > > Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
> > > > ---
> > > > John, please send this patch to the 2.6.24/2.6.25 stable trees.
> > > > It is already present in the wireless-2.6 tree queued for 2.6.26.
> > > >
> > > > drivers/net/wireless/rt2x00/rt2500usb.c | 2 +-
> > > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > > >
> > > > diff --git a/drivers/net/wireless/rt2x00/rt2500usb.c b/drivers/net/wireless/rt2x00/rt2500usb.c
> > > > index cba7f57..c4a6ab4 100644
> > > > --- a/drivers/net/wireless/rt2x00/rt2500usb.c
> > > > +++ b/drivers/net/wireless/rt2x00/rt2500usb.c
> > > > @@ -1871,11 +1871,11 @@ static struct usb_device_id rt2500usb_device_table[] = {
> > > > /* Hercules */
> > > > { USB_DEVICE(0x06f8, 0xe000), USB_DEVICE_DATA(&rt2500usb_ops) },
> > > > /* Melco */
> > > > + { USB_DEVICE(0x0411, 0x005e), USB_DEVICE_DATA(&rt2500usb_ops) },
> > > > { USB_DEVICE(0x0411, 0x0066), USB_DEVICE_DATA(&rt2500usb_ops) },
> > > > { USB_DEVICE(0x0411, 0x0067), USB_DEVICE_DATA(&rt2500usb_ops) },
> > > > { USB_DEVICE(0x0411, 0x008b), USB_DEVICE_DATA(&rt2500usb_ops) },
> > > > { USB_DEVICE(0x0411, 0x0097), USB_DEVICE_DATA(&rt2500usb_ops) },
> > > > -
> > > > /* MSI */
> > > > { USB_DEVICE(0x0db0, 0x6861), USB_DEVICE_DATA(&rt2500usb_ops) },
> > > > { USB_DEVICE(0x0db0, 0x6865), USB_DEVICE_DATA(&rt2500usb_ops) },
> > >
> > > I'm unsure on how this is an actual _fix_ that we need in a stable kernel.
> > > We always handled adding IDs as features.
> >
> > Ok, the user has to wait untill 2.6.26 then.
>
> Oh, it seems that -stable does actually accept such patches:
> http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.23.y.git;a=commitdiff;h=2cf220bb5b30a922aebdd5841a7975e02a70ce59
> http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.23.y.git;a=commitdiff;h=955ab48db7fb9e3d74dc770cca9aa6b194e53025
>
> I wasn't aware of this, because we always had the rule of ID additions
> being features, in the wireless team.
> So well. I think John should probably make an official decision. :)
>
> I would suggest the following: Unless there's another driver in
> the tree that (partially) supports the device being added, adding the ID
> can not cause a regression. So it's OK to add it, even in a stable cycle.
The ID was previously unknown, and I have 2 users who reported success when the
ID was added to rt2500usb and the legacy rt2570 driver.
Ivo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] rt2x00: Add new USB ID to rt2500usb
2008-02-10 12:22 ` Luis Correia
@ 2008-02-12 16:05 ` John W. Linville
0 siblings, 0 replies; 7+ messages in thread
From: John W. Linville @ 2008-02-12 16:05 UTC (permalink / raw)
To: Luis Correia; +Cc: Michael Buesch, Ivo van Doorn, linux-wireless
On Sun, Feb 10, 2008 at 12:22:30PM +0000, Luis Correia wrote:
> On Sun, Feb 10, 2008 at 10:31 AM, Michael Buesch <mb@bu3sch.de> wrote:
> > On Sunday 10 February 2008 11:21:57 Ivo van Doorn wrote:
> > > @@ -1871,11 +1871,11 @@ static struct usb_device_id rt2500usb_device_table[] = {
> > > /* Hercules */
> > > { USB_DEVICE(0x06f8, 0xe000), USB_DEVICE_DATA(&rt2500usb_ops) },
> > > /* Melco */
> > > + { USB_DEVICE(0x0411, 0x005e), USB_DEVICE_DATA(&rt2500usb_ops) },
> > > { USB_DEVICE(0x0411, 0x0066), USB_DEVICE_DATA(&rt2500usb_ops) },
> > > { USB_DEVICE(0x0411, 0x0067), USB_DEVICE_DATA(&rt2500usb_ops) },
> > > { USB_DEVICE(0x0411, 0x008b), USB_DEVICE_DATA(&rt2500usb_ops) },
> > > { USB_DEVICE(0x0411, 0x0097), USB_DEVICE_DATA(&rt2500usb_ops) },
> > > -
> > > /* MSI */
> > > { USB_DEVICE(0x0db0, 0x6861), USB_DEVICE_DATA(&rt2500usb_ops) },
> > > { USB_DEVICE(0x0db0, 0x6865), USB_DEVICE_DATA(&rt2500usb_ops) },
> >
> > I'm unsure on how this is an actual _fix_ that we need in a stable kernel.
> > We always handled adding IDs as features.
>
> Please forgive me for stepping in this apparently already closed discussion.
>
> Why is supporting a new USB ID considered a feature, when the users
> are probably ok with it (it works) and no changes are added to the
> code?
FWIW, I have often sent USB/PCI ID additions as "fixes" to the current
release. There may have been some confusion over that in the past --
if I created that confusion, I apologize. :-)
Thanks,
John
--
John W. Linville
linville@tuxdriver.com
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2008-02-12 16:31 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-10 10:21 [PATCH] rt2x00: Add new USB ID to rt2500usb Ivo van Doorn
2008-02-10 10:31 ` Michael Buesch
2008-02-10 10:36 ` Ivo van Doorn
2008-02-10 12:19 ` Michael Buesch
2008-02-10 12:33 ` Ivo van Doorn
2008-02-10 12:22 ` Luis Correia
2008-02-12 16:05 ` John W. Linville
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).