Re: [PATCH v2] mac80211: give burst time in txop rather than 0.1msec units

[Christian Lamparter <chunkeey@web.de>]

[-- Attachment #1: Type: text/plain, Size: 1348 bytes --]

On Sunday 10 February 2008 16:49:38 Johannes Berg wrote:

> Michael (Wu), the p54 driver has some values that differ from
> the 802.11 spec, is that intentional?
>

> +	/*
> +	 * FIXME: The default values in the spec (IEEE 802.11
> +	 *	  7.3.2.19 Table 37) are 47, 94, 0, 0, why use
> +	 *	  47, 94, 63, 0 here? Also, the default AIFS
> +	 *	  values (second parameter) are 2, 2, 3, 7...
> +	 */
Well, these values are the defaults of the original driver from conexant.
As far as I know it has something to do with the "proprietary" frameburst
feature (aka PRISM NITRO)... 

So on-topic: IEEE 802.11 defaults are fine. Drop the "FIXME". 

> +	P54_SET_QUEUE(vdcf->queue[0], 0x0002, 0x0003, 0x0007, 47);
> +	P54_SET_QUEUE(vdcf->queue[1], 0x0002, 0x0007, 0x000f, 94);
> +	P54_SET_QUEUE(vdcf->queue[2], 0x0003, 0x000f, 0x03ff, 0);
> +	P54_SET_QUEUE(vdcf->queue[3], 0x0007, 0x000f, 0x03ff, 0);

and off-topic: please merge another older patch. (see attachment)
>Re: [PATCH split 4/8] fix 'and' typo's in wireless/p54common
>Date: 26.10.2007 22:13
>From: Roel Kluin <12o3l@tiscali.nl>
>To: linux-wireless@vger.kernel.org
> 
>       Fix priority mistakes similar to '!x & y' in wireless/p54common
>    
>       Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
         Acked-by: Christian Lamparter <chunkeey@web.de>

[-- Attachment #2: roel-kluin-p54-negprio.patch --]
[-- Type: text/x-diff, Size: 588 bytes --]

diff --git a/drivers/net/wireless/p54common.c b/drivers/net/wireless/p54common.c
index 1437db0..8ee1453 100644
--- a/drivers/net/wireless/p54common.c
+++ b/drivers/net/wireless/p54common.c
@@ -374,7 +374,7 @@ static void p54_rx_frame_sent(struct ieee80211_hw *dev, struct sk_buff *skb)
 			if ((entry_hdr->magic1 & cpu_to_le16(0x4000)) != 0)
 				pad = entry_data->align[0];

-			if (!status.control.flags & IEEE80211_TXCTL_NO_ACK) {
+			if (!(status.control.flags & IEEE80211_TXCTL_NO_ACK)) {
 				if (!(payload->status & 0x01))
 					status.flags |= IEEE80211_TX_STATUS_ACK;
 				else