From: Christian Lamparter <chunkeey@web.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
Michael Wu <flamingice@sourmilk.net>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: [PATCH] p54: use IEEE 802.11e defaults for initialization
Date: Tue, 12 Feb 2008 14:02:06 +0100 [thread overview]
Message-ID: <200802121402.06985.chunkeey@web.de> (raw)
In-Reply-To: <1202815900.8931.1.camel@johannes.berg>
[-- Attachment #1: Type: text/plain, Size: 415 bytes --]
This trival one-liner changes the QoS initialization values to match IEEE
802.11e defaults.
Signed-off-by: Christian Lamparter <chunkeey@web.de>
---
Johannes:
Which tree do you want? I made two versions.
1. ...-2.6.24.2.diff will be fine for the mainline and the everything branch.
2. ...-txoppatch.diff is made for "[PATCH v2] mac80211: give burst time in
txop rather than 0.1msec units" (with some offset?!)
[-- Attachment #2: p54-ieee-qos-values-against-2.6.24.2.diff --]
[-- Type: text/x-diff, Size: 574 bytes --]
--- linux-2.6.24.2/drivers/net/wireless/p54common.c.orig 2008-02-12 13:22:26.803058257 +0100
+++ linux-2.6.24.2/drivers/net/wireless/p54common.c 2008-02-12 13:24:21.096297635 +0100
@@ -742,7 +742,7 @@ static void p54_init_vdcf(struct ieee802
P54_SET_QUEUE(vdcf->queue[0], 0x0002, 0x0003, 0x0007, 0x000f);
P54_SET_QUEUE(vdcf->queue[1], 0x0002, 0x0007, 0x000f, 0x001e);
- P54_SET_QUEUE(vdcf->queue[2], 0x0002, 0x000f, 0x03ff, 0x0014);
+ P54_SET_QUEUE(vdcf->queue[2], 0x0003, 0x000f, 0x03ff, 0x0000);
P54_SET_QUEUE(vdcf->queue[3], 0x0007, 0x000f, 0x03ff, 0x0000);
}
[-- Attachment #3: p54-ieee-qos-values-against-txoppatch.diff --]
[-- Type: text/x-diff, Size: 818 bytes --]
--- everything/drivers/net/wireless/p54common.c.orig 2008-02-12 13:37:48.723005027 +0100
+++ everythinh/drivers/net/wireless/p54common.c 2008-02-12 13:38:09.200480691 +0100
@@ -740,15 +740,9 @@ static void p54_init_vdcf(struct ieee802
vdcf = (struct p54_tx_control_vdcf *) hdr->data;
- /*
- * FIXME: The default values in the spec (IEEE 802.11
- * 7.3.2.19 Table 37) are 47, 94, 0, 0, why use
- * 47, 94, 63, 0 here? Also, the default AIFS
- * values (second parameter) are 2, 2, 3, 7...
- */
P54_SET_QUEUE(vdcf->queue[0], 0x0002, 0x0003, 0x0007, 47);
P54_SET_QUEUE(vdcf->queue[1], 0x0002, 0x0007, 0x000f, 94);
- P54_SET_QUEUE(vdcf->queue[2], 0x0002, 0x000f, 0x03ff, 63);
+ P54_SET_QUEUE(vdcf->queue[2], 0x0003, 0x000f, 0x03ff, 0);
P54_SET_QUEUE(vdcf->queue[3], 0x0007, 0x000f, 0x03ff, 0);
}
next prev parent reply other threads:[~2008-02-12 13:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-10 15:49 [PATCH v2] mac80211: give burst time in txop rather than 0.1msec units Johannes Berg
2008-02-11 18:52 ` Christian Lamparter
2008-02-12 11:31 ` Johannes Berg
2008-02-12 13:02 ` Christian Lamparter [this message]
2008-02-13 12:11 ` [PATCH] p54: use IEEE 802.11e defaults for initialization Johannes Berg
2008-02-12 19:21 ` [PATCH v2] mac80211: give burst time in txop rather than 0.1msec units Michael Buesch
2008-02-12 19:57 ` Tomas Winkler
2008-02-12 20:42 ` Michael Buesch
2008-02-13 12:10 ` Johannes Berg
2008-02-12 16:26 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802121402.06985.chunkeey@web.de \
--to=chunkeey@web.de \
--cc=flamingice@sourmilk.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).