From: "John W. Linville" <linville@tuxdriver.com>
To: Christian Lamparter <chunkeey@web.de>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Tomas Winkler <tomasw@gmail.com>,
Michael Wu <flamingice@sourmilk.net>,
Michael Buesch <mb@bu3sch.de>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] mac80211: give burst time in txop rather than 0.1msec units
Date: Tue, 12 Feb 2008 11:26:45 -0500 [thread overview]
Message-ID: <20080212162645.GD3051@tuxdriver.com> (raw)
In-Reply-To: <200802111952.30964.chunkeey@web.de>
On Mon, Feb 11, 2008 at 07:52:30PM +0100, Christian Lamparter wrote:
> and off-topic: please merge another older patch. (see attachment)
> >Re: [PATCH split 4/8] fix 'and' typo's in wireless/p54common
> >Date: 26.10.2007 22:13
> >From: Roel Kluin <12o3l@tiscali.nl>
> >To: linux-wireless@vger.kernel.org
> >=20
> > =A0 =A0 =A0 Fix priority mistakes similar to '!x & y' in wireless/p=
54common
> >=A0 =A0=20
> > =A0 =A0 =A0 Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> Acked-by: Christian Lamparter <chunkeey@web.de>
> diff --git a/drivers/net/wireless/p54common.c b/drivers/net/wireless/=
p54common.c
> index 1437db0..8ee1453 100644
> --- a/drivers/net/wireless/p54common.c
> +++ b/drivers/net/wireless/p54common.c
> @@ -374,7 +374,7 @@ static void p54_rx_frame_sent(struct ieee80211_hw=
*dev, struct sk_buff *skb)
> if ((entry_hdr->magic1 & cpu_to_le16(0x4000)) !=3D 0)
> pad =3D entry_data->align[0];
>=20
> - if (!status.control.flags & IEEE80211_TXCTL_NO_ACK) {
> + if (!(status.control.flags & IEEE80211_TXCTL_NO_ACK)) {
> if (!(payload->status & 0x01))
> status.flags |=3D IEEE80211_TX_STATUS_ACK;
> else
>=20
This is part of the commit here:
commit f59d9782751bf1a2c51e7e1e9f614ffec35fb52e
Author: Roel Kluin <12o3l@tiscali.nl>
Date: Fri Oct 26 21:51:26 2007 +0200
wireless: fix '!x & y' typo's
Fix priority mistakes similar to '!x & y'
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Hth!
--=20
John W. Linville
linville@tuxdriver.com
-
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-02-12 17:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-10 15:49 [PATCH v2] mac80211: give burst time in txop rather than 0.1msec units Johannes Berg
2008-02-11 18:52 ` Christian Lamparter
2008-02-12 11:31 ` Johannes Berg
2008-02-12 13:02 ` [PATCH] p54: use IEEE 802.11e defaults for initialization Christian Lamparter
2008-02-13 12:11 ` Johannes Berg
2008-02-12 19:21 ` [PATCH v2] mac80211: give burst time in txop rather than 0.1msec units Michael Buesch
2008-02-12 19:57 ` Tomas Winkler
2008-02-12 20:42 ` Michael Buesch
2008-02-13 12:10 ` Johannes Berg
2008-02-12 16:26 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080212162645.GD3051@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=chunkeey@web.de \
--cc=flamingice@sourmilk.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=tomasw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).