Re: [PATCH RFT/RFC] b43: Add QOS support

[Michael Buesch <mb@bu3sch.de>]

On Tuesday 12 February 2008 22:05:42 Michael Buesch wrote:
> This patch adds QOS support for b43.
> Please comment on this and test this.
> This patch depends on Johannes' "burst time -> txop patch" being _not_ applied.
> One can trivially fix that, though.
> +	for (i = 0; i < ARRAY_SIZE(wl->qos_params); i++) {
> +		params = &(wl->qos_params[i]);
> +		if (params->need_hw_update) {
> +			b43_qos_params_upload(dev, &(params->p),
> +					      qos_shm_offsets[i]);
> +			params->need_hw_update = 1;

Whoopsy, needs to be:
			params->need_hw_update = 0;

> +		}
> +	}
> +
> +	spin_unlock_irqrestore(&wl->irq_lock, flags);
> +	b43_mac_enable(dev);
> +}

> +/* Initialize the core's QOS capabilities */
> +static void b43_qos_init(struct b43_wldev *dev)
> +{
> +	/* Upload the current QOS parameters. */

And here we need a loop setting all "need_hw_update" to 1.

> +	b43_qos_update(dev);
> +	/* Enable QOS support. */
> +	b43_hf_write(dev, b43_hf_read(dev) | B43_HF_EDCF);
> +	b43_write16(dev, B43_MMIO_IFSCTL,
> +		    b43_read16(dev, B43_MMIO_IFSCTL)
> +		    | B43_MMIO_IFSCTL_USE_EDCF);
> +}

-- 
Greetings Michael.