From: Michael Buesch <mb@bu3sch.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org,
Stefano Brivio <stefano.brivio@polimi.it>
Subject: Re: [PATCH RFT/RFC] b43: Add QOS support
Date: Wed, 13 Feb 2008 13:14:34 +0100 [thread overview]
Message-ID: <200802131314.34930.mb@bu3sch.de> (raw)
In-Reply-To: <1202904473.8931.31.camel@johannes.berg>
On Wednesday 13 February 2008 13:07:53 Johannes Berg wrote:
>
> > + if (queue >= ARRAY_SIZE(wl->qos_params)) {
> > + /* Queue not available or don't support setting
> > + * params on this queue. Return success to not
> > + * confuse mac80211. */
> > + return 0;
> > + }
>
> Is that really necessary? If so, I'll probably remove it when doing the
> QoS rework, it shouldn't be, imho you should return an error if mac80211
> tries to configure a queue >= hw.queues.
Yep, mac80211 walks the whole queue array without looking at hw->queues.
I think this needs fixing in mac80211.
--
Greetings Michael.
next prev parent reply other threads:[~2008-02-13 12:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-12 21:05 [PATCH RFT/RFC] b43: Add QOS support Michael Buesch
2008-02-12 21:12 ` Michael Buesch
2008-02-12 22:56 ` Michael Buesch
2008-02-13 12:08 ` Johannes Berg
2008-02-13 13:30 ` Johannes Berg
2008-02-13 12:07 ` Johannes Berg
2008-02-13 12:14 ` Michael Buesch [this message]
2008-02-13 12:19 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802131314.34930.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=stefano.brivio@polimi.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).