Re: ath5k: reset for 5424-based card

[Bob Copeland <me@bobcopeland.com>]

I spent a bunch of reboots on trying to narrow down what needs to stay
and what can go.  Driver is still a little flaky for this card; I'd say
about one third of the time I do an insmod the card gets hung and I need
to reboot.  That makes it harder to rule certain changes in/out.

Also, the calibration stuff will hang more than half the time if we
reset everything but the CTL_PCI.  I've gone back to just resetting _PCU 
and _BASEBAND for now.  Maybe this wants a card-specific flag, or like
Jiri's patch just skip the second reset?

> Have you tried 256 ? Also have you tried only setting lower dma size for rx ?

512 for tx definitely did not work.  Will try 256 and let you know.

> > +       if (ah->ah_mac_srev >= AR5K_SREV_VER_AR2424) {
> > +               ath5k_hw_reg_write(ah, 0x000100aa, 0x8118);
> > +               ath5k_hw_reg_write(ah, 0x00003210, 0x811c);
> > +               ath5k_hw_reg_write(ah, 0x00000052, 0x8108);
> > +               ath5k_hw_reg_write(ah, 0x001e1e1e, AR5K_TXPC);
> 
> Remove TXPC and see what happens...

Yep TXPC can absolutely go.  0x8118 can probably go away too.  Still unsure 
about 811c/8108.

> > +               ath5k_hw_reg_write(ah, 0x00000004, 0x8120);

It never worked without this one.

-- 
Bob Copeland %% www.bobcopeland.com