From: Sam Ravnborg <sam@ravnborg.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Stefano Brivio <stefano.brivio@polimi.it>
Subject: Re: [PATCH] mac80211: check endianness/types in sparse runs
Date: Wed, 20 Feb 2008 20:59:13 +0100 [thread overview]
Message-ID: <20080220195913.GE21139@uranus.ravnborg.org> (raw)
In-Reply-To: <1203503909.17534.14.camel@johannes.berg>
On Wed, Feb 20, 2008 at 11:38:29AM +0100, Johannes Berg wrote:
> Make sure sparse checks endianness when run on mac80211.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> ---
> Sam, is this an OK use of makefiles or is there something else I should
> be doing?
I would prefer it to be kernel wide enabled.
Tried a defconfig build.
When I enabled __CHECK_ENDIAN I got:
8 files with > 100 warnings
14 files with 10 to 99 warnings.
So nothing that should scare a kernel hacker...
warnings without: 1686
warnings with: 2788
OK - thats a lot, but then fixing 8 files will significantly
reduce this.
Sam
next prev parent reply other threads:[~2008-02-20 19:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-20 10:38 [PATCH] mac80211: check endianness/types in sparse runs Johannes Berg
2008-02-20 19:59 ` Sam Ravnborg [this message]
2008-02-20 20:07 ` Pavel Roskin
2008-02-21 12:42 ` Johannes Berg
2008-02-21 20:01 ` Harvey Harrison
2008-02-21 22:32 ` __bitwise versus __bitwise__ [Was: [PATCH] mac80211: check endianness/types in sparse runs] Sam Ravnborg
2008-02-21 22:38 ` Al Viro
2008-02-21 20:06 ` [PATCH] mac80211: check endianness/types in sparse runs Sam Ravnborg
2008-02-21 20:09 ` Johannes Berg
2008-02-21 20:25 ` Harvey Harrison
2008-02-21 20:29 ` Johannes Berg
2008-02-21 20:33 ` Harvey Harrison
2008-02-21 21:16 ` Al Viro
2008-02-22 14:02 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080220195913.GE21139@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=stefano.brivio@polimi.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).