From: "John W. Linville" <linville@tuxdriver.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: bruno randolf <br1@einfach.org>,
"Luis R. Rodriguez" <mcgrof@gmail.com>,
Michael Renzmann <mrenzmann@madwifi.org>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: when does ath5k filter frames?
Date: Wed, 20 Feb 2008 15:25:18 -0500 [thread overview]
Message-ID: <20080220202518.GD3825@tuxdriver.com> (raw)
In-Reply-To: <1203514108.17534.41.camel@johannes.berg>
On Wed, Feb 20, 2008 at 02:28:28PM +0100, Johannes Berg wrote:
> Hi,
>
> In mac80211 we have a whole bunch of cryptic code to handle "filtered"
> frames. The only driver that does that seems to be ath5k, and it doesn't
> really seem to use this since it is intimately tied to
> IEEE80211_TXCTL_CLEAR_DST_MASK which it doesn't check...
>
> Any ideas? Should we kill all this code and not use whatever hardware
> powersave helpers atheros hardware might have?
>
> On the other hand, Broadcom also has powersave helpers in
> hardware/firmware, maybe we should generalise to be able to use them as
> well?
Do we understand either of these (i.e. Broadcom or Atheros) helpers
well enough to utilize them? If so, it sounds like a nice feature
to support. Hardware/firmware may be able to do nifty things to
save power.
If we don't really know how those helpers work, it may be better just
to remove the unused infrastructure.
Is my opinion useful? :-)
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2008-02-20 20:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-20 13:28 when does ath5k filter frames? Johannes Berg
2008-02-20 20:25 ` John W. Linville [this message]
2008-02-21 9:28 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080220202518.GD3825@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=br1@einfach.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
--cc=mrenzmann@madwifi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).