when does ath5k filter frames?

when does ath5k filter frames?

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 541 bytes --]

Hi,

In mac80211 we have a whole bunch of cryptic code to handle "filtered"
frames. The only driver that does that seems to be ath5k, and it doesn't
really seem to use this since it is intimately tied to
IEEE80211_TXCTL_CLEAR_DST_MASK which it doesn't check...

Any ideas? Should we kill all this code and not use whatever hardware
powersave helpers atheros hardware might have?

On the other hand, Broadcom also has powersave helpers in
hardware/firmware, maybe we should generalise to be able to use them as
well?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: when does ath5k filter frames?

[John W. Linville]

On Wed, Feb 20, 2008 at 02:28:28PM +0100, Johannes Berg wrote:
> Hi,
> 
> In mac80211 we have a whole bunch of cryptic code to handle "filtered"
> frames. The only driver that does that seems to be ath5k, and it doesn't
> really seem to use this since it is intimately tied to
> IEEE80211_TXCTL_CLEAR_DST_MASK which it doesn't check...
> 
> Any ideas? Should we kill all this code and not use whatever hardware
> powersave helpers atheros hardware might have?
> 
> On the other hand, Broadcom also has powersave helpers in
> hardware/firmware, maybe we should generalise to be able to use them as
> well?

Do we understand either of these (i.e. Broadcom or Atheros) helpers
well enough to utilize them?  If so, it sounds like a nice feature
to support.  Hardware/firmware may be able to do nifty things to
save power.

If we don't really know how those helpers work, it may be better just
to remove the unused infrastructure.

Is my opinion useful? :-)

John
-- 
John W. Linville
linville@tuxdriver.com

Re: when does ath5k filter frames?

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 275 bytes --]


> Do we understand either of these (i.e. Broadcom or Atheros) helpers
> well enough to utilize them?  If so, it sounds like a nice feature
> to support.  Hardware/firmware may be able to do nifty things to
> save power.

I'm talking about master mode. :)

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]