linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Ron Rindjunsky <ron.rindjunsky@intel.com>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: mac80211: sta info locking
Date: Fri, 22 Feb 2008 10:57:04 -0500	[thread overview]
Message-ID: <20080222155704.GD3067@tuxdriver.com> (raw)
In-Reply-To: <1203693409.7082.30.camel@johannes.berg>

On Fri, Feb 22, 2008 at 04:16:49PM +0100, Johannes Berg wrote:
> 
> > > Hence, I think we can actually get away without more locking if we
> > > protect the flags better. Should we use a spinlock or the atomic
> > > set_bit()/clear_bit()/etc. operations?
> > 
> > Using the atomic operations seems appropriate to me.
> 
> Right, but I figured if we could get rid of the AMPDU spinlocks and just
> use a single one in total (for flags as well) then that'd be of benefit
> too; even with the dynamic allocation strategy (see other mail) we'd not
> need to allocate two more spinlocks for ampdu.

Yes, I thought that was behind your question.  I'll let Ron comment
on the AMPDU spinlock usage.

John
-- 
John W. Linville
linville@tuxdriver.com

  reply	other threads:[~2008-02-22 16:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-22 10:44 mac80211: sta info locking Johannes Berg
2008-02-22 14:37 ` John W. Linville
2008-02-22 15:16   ` Johannes Berg
2008-02-22 15:57     ` John W. Linville [this message]
2008-02-25 20:46       ` Johannes Berg
2008-02-25 22:50         ` Tomas Winkler
2008-02-25 22:55           ` Johannes Berg
2008-02-25 23:12             ` Tomas Winkler
2008-02-25 23:23               ` Johannes Berg
2008-02-25 23:41                 ` Tomas Winkler
2008-02-25 23:48                   ` Johannes Berg
2008-02-26  0:30                     ` Tomas Winkler
2008-02-26  9:59                       ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080222155704.GD3067@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=ron.rindjunsky@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).