From: Christoph Hellwig <hch@infradead.org>
To: ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org,
linville@tuxdriver.com, bruno@thinktube.com, jirislaby@gmail.com,
mcgrof@gmail.com
Subject: Re: [PATCH 6/8] ath5k: Fixes for PCI-E cards
Date: Sun, 24 Feb 2008 15:16:11 -0500 [thread overview]
Message-ID: <20080224201611.GA20715@infradead.org> (raw)
In-Reply-To: <20080224042851.GE4426@makis.domain.invalid>
On Sun, Feb 24, 2008 at 06:28:51AM +0200, Nick Kossifidis wrote:
> + if((srev >= AR5K_SREV_VER_AR2424 && srev <= AR5K_SREV_VER_AR5424) ||
> + srev >= AR5K_SREV_VER_AR5416) {
> + ah->ah_pcie = true;
> + } else {
> + ah->ah_pcie = false;
> + }
Sorry for beeing nitpicky. but the indentation/spacing bracing here
seems just too odd :)
This should be something like:
if ((srev >= AR5K_SREV_VER_AR2424 && srev <= AR5K_SREV_VER_AR5424) ||
srev >= AR5K_SREV_VER_AR5416)
ah->ah_pcie = true;
else
ah->ah_pcie = false;
or even better just leave the else clause out because ah has presumably
been zeroed before.
next prev parent reply other threads:[~2008-02-24 20:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-24 4:28 [PATCH 6/8] ath5k: Fixes for PCI-E cards Nick Kossifidis
2008-02-24 4:45 ` [ath5k-devel] " Nick Kossifidis
2008-02-24 4:47 ` Nick Kossifidis
2008-02-24 16:09 ` Bob Copeland
2008-02-24 17:59 ` Bob Copeland
2008-02-24 18:58 ` Nick Kossifidis
2008-02-24 20:21 ` Bob Copeland
2008-02-24 23:23 ` Nick Kossifidis
2008-02-27 3:23 ` Luis R. Rodriguez
2008-02-27 5:54 ` Nick Kossifidis
2008-02-27 13:30 ` Luis R. Rodriguez
2008-02-27 15:52 ` John W. Linville
2008-02-27 18:44 ` Nick Kossifidis
2008-02-28 22:20 ` Luis R. Rodriguez
2008-02-24 23:48 ` Nick Kossifidis
2008-02-25 2:23 ` Bob Copeland
2008-02-25 14:20 ` Nick Kossifidis
2008-02-24 20:17 ` Christoph Hellwig
2008-02-24 23:27 ` Nick Kossifidis
2008-02-24 20:16 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-02-28 22:56 [PATCH 1/8] ath5k: Add RF2413 srev values Luis R. Rodriguez
2008-02-28 22:59 ` [PATCH 6/8] ath5k: Fixes for PCI-E cards Luis R. Rodriguez
2008-02-29 2:03 ` Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080224201611.GA20715@infradead.org \
--to=hch@infradead.org \
--cc=ath5k-devel@lists.ath5k.org \
--cc=bruno@thinktube.com \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).