From: "John W. Linville" <linville@tuxdriver.com>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: Nick Kossifidis <mickflemm@gmail.com>,
Bob Copeland <me@bobcopeland.com>,
ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org,
bruno@thinktube.com, jirislaby@gmail.com
Subject: Re: [ath5k-devel] [PATCH 6/8] ath5k: Fixes for PCI-E cards
Date: Wed, 27 Feb 2008 10:52:57 -0500 [thread overview]
Message-ID: <20080227155257.GC3078@tuxdriver.com> (raw)
In-Reply-To: <43e72e890802270530j6ca4a6eal832d642a94a49e94@mail.gmail.com>
On Wed, Feb 27, 2008 at 08:30:18AM -0500, Luis R. Rodriguez wrote:
> On Wed, Feb 27, 2008 at 12:54 AM, Nick Kossifidis <mickflemm@gmail.com> wrote:
> > What if there is a pci-e card in the future that needs _PCI bit ?
>
> I don't follow, the member is for struct pci_dev so its either a pci
> or pci-express device. If you mean what if we later have some srev in
> the range that is not pci-e, well then we'd use srevs wouldn't we?
>
> > I guess for now we can work on with srevs to be safe but it's good to
> > know of that feature, thanx ;-)
>
> The point is that if there is already a variable we can use to detect
> if a device is pci-e then we shouldn't introduce any other new ones.
ACK for Luis's point.
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2008-02-27 16:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-24 4:28 [PATCH 6/8] ath5k: Fixes for PCI-E cards Nick Kossifidis
2008-02-24 4:45 ` [ath5k-devel] " Nick Kossifidis
2008-02-24 4:47 ` Nick Kossifidis
2008-02-24 16:09 ` Bob Copeland
2008-02-24 17:59 ` Bob Copeland
2008-02-24 18:58 ` Nick Kossifidis
2008-02-24 20:21 ` Bob Copeland
2008-02-24 23:23 ` Nick Kossifidis
2008-02-27 3:23 ` Luis R. Rodriguez
2008-02-27 5:54 ` Nick Kossifidis
2008-02-27 13:30 ` Luis R. Rodriguez
2008-02-27 15:52 ` John W. Linville [this message]
2008-02-27 18:44 ` Nick Kossifidis
2008-02-28 22:20 ` Luis R. Rodriguez
2008-02-24 23:48 ` Nick Kossifidis
2008-02-25 2:23 ` Bob Copeland
2008-02-25 14:20 ` Nick Kossifidis
2008-02-24 20:17 ` Christoph Hellwig
2008-02-24 23:27 ` Nick Kossifidis
2008-02-24 20:16 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2008-02-25 15:43 [ath5k-devel] " Bob Copeland
2008-02-26 2:13 ` bruno randolf
2008-02-26 3:51 ` Bob Copeland
2008-02-26 3:57 ` Nick Kossifidis
2008-02-26 4:39 ` Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080227155257.GC3078@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=bruno@thinktube.com \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
--cc=me@bobcopeland.com \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).