Re: drivers/net/wireless/b43legacy/ on mips

[Michael Buesch <mb@bu3sch.de>]

On Tuesday 04 March 2008 08:36:51 Andrew Morton wrote:
> 
> ERROR: "__ucmpdi2" [drivers/net/wireless/b43legacy/b43legacy.ko] undefined!
> ERROR: "__ucmpdi2" [drivers/net/wireless/b43/b43.ko] undefined!
> 
> int b43legacy_dma_init(struct b43legacy_wldev *dev)
> {
>         struct b43legacy_dma *dma = &dev->dma;
>         struct b43legacy_dmaring *ring;
>         int err;
>         u64 dmamask;
>         enum b43legacy_dmatype type;
> 
>         dmamask = supported_dma_mask(dev);
>         switch (dmamask) {
>         default:
>                 B43legacy_WARN_ON(1);
>         case DMA_30BIT_MASK:
>                 type = B43legacy_DMA_30BIT;
>                 break;
>         case DMA_32BIT_MASK:
>                 type = B43legacy_DMA_32BIT;
>                 break;
>         case DMA_64BIT_MASK:
>                 type = B43legacy_DMA_64BIT;
>                 break;
>         }
> 
> because some versions of gcc emit a __ucmpdi2 call for switch statements. 
> It might be fixable by switching to an open-coded if/compare/else sequence.

I guess that's only done for a 64bit data type, right?

> Or maybe my mips compiler (gcc-3.4.5) is just too old..

Well yeah. b43 uses exactly the same code and we use that in openwrt
on the bcm47xx mips platform with some 4.x compiler.

Can we switch off the generation of the __ucmpdi2 call somehow?
Or can we insert an implementation for it? Probably #ifdefed by the
compiler version.

-- 
Greetings Michael.