* [PATCH] wireless: rt2x00: fix driver menu indenting
[not found] <200802091623.06504.m.bueker@berlin.de>
@ 2008-02-10 18:52 ` Randy Dunlap
2008-02-10 19:03 ` [Rt2400-devel] " Ivo van Doorn
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2008-02-10 18:52 UTC (permalink / raw)
To: linux-wireless, rt2400-devel
Cc: linux-kernel, Michael Büker, linville, akpm
On Sat, 9 Feb 2008 16:23:06 +0100 Michael B=FCker wrote:
> 2) When selecting "Ralink driver support" (CONFIG_RT2X00), the accomp=
anying=20
> drivers (CONFIG_RT2400PCI, CONFIG_RT61PC, ...) appear unindented. The=
y should=20
> be indented by four spaces.
Yes, patch is below.
---
=46rom: Randy Dunlap <randy.dunlap@oracle.com>
Michael B=FCker <m.bueker@berlin.de> reports that the RT2x00 drivers
are not indented as they should be, so use proper dependencies to make
them be indented as expected.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/net/wireless/rt2x00/Kconfig | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
--- linux-2.6.24-git21.orig/drivers/net/wireless/rt2x00/Kconfig
+++ linux-2.6.24-git21/drivers/net/wireless/rt2x00/Kconfig
@@ -11,18 +11,17 @@ config RT2X00
will also be created. That library (when the driver is built as
a module) will be called "rt2x00lib.ko".
=20
+if RT2X00
+
config RT2X00_LIB
tristate
- depends on RT2X00
=20
config RT2X00_LIB_PCI
tristate
- depends on RT2X00
select RT2X00_LIB
=20
config RT2X00_LIB_USB
tristate
- depends on RT2X00
select RT2X00_LIB
=20
config RT2X00_LIB_FIRMWARE
@@ -39,7 +38,7 @@ config RT2X00_LIB_RFKILL
=20
config RT2400PCI
tristate "Ralink rt2400 pci/pcmcia support"
- depends on RT2X00 && PCI
+ depends on PCI
select RT2X00_LIB_PCI
select EEPROM_93CX6
---help---
@@ -58,7 +57,7 @@ config RT2400PCI_RFKILL
=20
config RT2500PCI
tristate "Ralink rt2500 pci/pcmcia support"
- depends on RT2X00 && PCI
+ depends on PCI
select RT2X00_LIB_PCI
select EEPROM_93CX6
---help---
@@ -77,7 +76,7 @@ config RT2500PCI_RFKILL
=20
config RT61PCI
tristate "Ralink rt61 pci/pcmcia support"
- depends on RT2X00 && PCI
+ depends on PCI
select RT2X00_LIB_PCI
select RT2X00_LIB_FIRMWARE
select EEPROM_93CX6
@@ -97,7 +96,7 @@ config RT61PCI_RFKILL
=20
config RT2500USB
tristate "Ralink rt2500 usb support"
- depends on RT2X00 && USB
+ depends on USB
select RT2X00_LIB_USB
---help---
This is an experimental driver for the Ralink rt2500 wireless chip.
@@ -106,7 +105,7 @@ config RT2500USB
=20
config RT73USB
tristate "Ralink rt73 usb support"
- depends on RT2X00 && USB
+ depends on USB
select RT2X00_LIB_USB
select RT2X00_LIB_FIRMWARE
---help---
@@ -128,3 +127,4 @@ config RT2X00_DEBUG
---help---
Enable debugging output for all rt2x00 modules
=20
+endif
-
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Rt2400-devel] [PATCH] wireless: rt2x00: fix driver menu indenting
2008-02-10 18:52 ` [PATCH] wireless: rt2x00: fix driver menu indenting Randy Dunlap
@ 2008-02-10 19:03 ` Ivo van Doorn
2008-03-05 6:00 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Ivo van Doorn @ 2008-02-10 19:03 UTC (permalink / raw)
To: rt2400-devel
Cc: Randy Dunlap, linux-wireless, Michael Büker, linux-kernel,
akpm, linville
On Sunday 10 February 2008, Randy Dunlap wrote:
> On Sat, 9 Feb 2008 16:23:06 +0100 Michael B=FCker wrote:
>=20
> > 2) When selecting "Ralink driver support" (CONFIG_RT2X00), the acco=
mpanying=20
> > drivers (CONFIG_RT2400PCI, CONFIG_RT61PC, ...) appear unindented. T=
hey should=20
> > be indented by four spaces.
>=20
> Yes, patch is below.
>=20
> ---
> From: Randy Dunlap <randy.dunlap@oracle.com>
>=20
> Michael B=FCker <m.bueker@berlin.de> reports that the RT2x00 drivers
> are not indented as they should be, so use proper dependencies to mak=
e
> them be indented as expected.
>=20
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Ack-by: Ivo van Doorn <IvDoorn@gmail.com>
---
John,
Could you push this directly into wireless-2.6 and probably upstream as=
well.
Thanks.
Ivo
> ---
> drivers/net/wireless/rt2x00/Kconfig | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>=20
> --- linux-2.6.24-git21.orig/drivers/net/wireless/rt2x00/Kconfig
> +++ linux-2.6.24-git21/drivers/net/wireless/rt2x00/Kconfig
> @@ -11,18 +11,17 @@ config RT2X00
> will also be created. That library (when the driver is built as
> a module) will be called "rt2x00lib.ko".
> =20
> +if RT2X00
> +
> config RT2X00_LIB
> tristate
> - depends on RT2X00
> =20
> config RT2X00_LIB_PCI
> tristate
> - depends on RT2X00
> select RT2X00_LIB
> =20
> config RT2X00_LIB_USB
> tristate
> - depends on RT2X00
> select RT2X00_LIB
> =20
> config RT2X00_LIB_FIRMWARE
> @@ -39,7 +38,7 @@ config RT2X00_LIB_RFKILL
> =20
> config RT2400PCI
> tristate "Ralink rt2400 pci/pcmcia support"
> - depends on RT2X00 && PCI
> + depends on PCI
> select RT2X00_LIB_PCI
> select EEPROM_93CX6
> ---help---
> @@ -58,7 +57,7 @@ config RT2400PCI_RFKILL
> =20
> config RT2500PCI
> tristate "Ralink rt2500 pci/pcmcia support"
> - depends on RT2X00 && PCI
> + depends on PCI
> select RT2X00_LIB_PCI
> select EEPROM_93CX6
> ---help---
> @@ -77,7 +76,7 @@ config RT2500PCI_RFKILL
> =20
> config RT61PCI
> tristate "Ralink rt61 pci/pcmcia support"
> - depends on RT2X00 && PCI
> + depends on PCI
> select RT2X00_LIB_PCI
> select RT2X00_LIB_FIRMWARE
> select EEPROM_93CX6
> @@ -97,7 +96,7 @@ config RT61PCI_RFKILL
> =20
> config RT2500USB
> tristate "Ralink rt2500 usb support"
> - depends on RT2X00 && USB
> + depends on USB
> select RT2X00_LIB_USB
> ---help---
> This is an experimental driver for the Ralink rt2500 wireless chi=
p.
> @@ -106,7 +105,7 @@ config RT2500USB
> =20
> config RT73USB
> tristate "Ralink rt73 usb support"
> - depends on RT2X00 && USB
> + depends on USB
> select RT2X00_LIB_USB
> select RT2X00_LIB_FIRMWARE
> ---help---
> @@ -128,3 +127,4 @@ config RT2X00_DEBUG
> ---help---
> Enable debugging output for all rt2x00 modules
> =20
> +endif
>=20
> ---------------------------------------------------------------------=
----
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Rt2400-devel mailing list
> Rt2400-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/rt2400-devel
>=20
-
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Rt2400-devel] [PATCH] wireless: rt2x00: fix driver menu indenting
2008-02-10 19:03 ` [Rt2400-devel] " Ivo van Doorn
@ 2008-03-05 6:00 ` Randy Dunlap
2008-03-05 18:11 ` John W. Linville
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2008-03-05 6:00 UTC (permalink / raw)
To: Ivo van Doorn
Cc: rt2400-devel, linux-wireless, Michael Büker, linux-kernel,
akpm, linville
On Sun, 10 Feb 2008 20:03:25 +0100 Ivo van Doorn wrote:
> On Sunday 10 February 2008, Randy Dunlap wrote:
> > On Sat, 9 Feb 2008 16:23:06 +0100 Michael B=FCker wrote:
> >=20
> > > 2) When selecting "Ralink driver support" (CONFIG_RT2X00), the ac=
companying=20
> > > drivers (CONFIG_RT2400PCI, CONFIG_RT61PC, ...) appear unindented.=
They should=20
> > > be indented by four spaces.
> >=20
> > Yes, patch is below.
> >=20
> > ---
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> >=20
> > Michael B=FCker <m.bueker@berlin.de> reports that the RT2x00 driver=
s
> > are not indented as they should be, so use proper dependencies to m=
ake
> > them be indented as expected.
> >=20
> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>=20
> Ack-by: Ivo van Doorn <IvDoorn@gmail.com>
>=20
> ---
> John,
> Could you push this directly into wireless-2.6 and probably upstream =
as well.
>=20
> Thanks.
>=20
> Ivo
John, do you have this patch queued somewhere?
> > ---
> > drivers/net/wireless/rt2x00/Kconfig | 16 ++++++++--------
> > 1 file changed, 8 insertions(+), 8 deletions(-)
> >=20
> > --- linux-2.6.24-git21.orig/drivers/net/wireless/rt2x00/Kconfig
> > +++ linux-2.6.24-git21/drivers/net/wireless/rt2x00/Kconfig
> > @@ -11,18 +11,17 @@ config RT2X00
> > will also be created. That library (when the driver is built as
> > a module) will be called "rt2x00lib.ko".
> > =20
> > +if RT2X00
> > +
> > config RT2X00_LIB
> > tristate
> > - depends on RT2X00
> > =20
> > config RT2X00_LIB_PCI
> > tristate
> > - depends on RT2X00
> > select RT2X00_LIB
> > =20
> > config RT2X00_LIB_USB
> > tristate
> > - depends on RT2X00
> > select RT2X00_LIB
> > =20
> > config RT2X00_LIB_FIRMWARE
> > @@ -39,7 +38,7 @@ config RT2X00_LIB_RFKILL
> > =20
> > config RT2400PCI
> > tristate "Ralink rt2400 pci/pcmcia support"
> > - depends on RT2X00 && PCI
> > + depends on PCI
> > select RT2X00_LIB_PCI
> > select EEPROM_93CX6
> > ---help---
> > @@ -58,7 +57,7 @@ config RT2400PCI_RFKILL
> > =20
> > config RT2500PCI
> > tristate "Ralink rt2500 pci/pcmcia support"
> > - depends on RT2X00 && PCI
> > + depends on PCI
> > select RT2X00_LIB_PCI
> > select EEPROM_93CX6
> > ---help---
> > @@ -77,7 +76,7 @@ config RT2500PCI_RFKILL
> > =20
> > config RT61PCI
> > tristate "Ralink rt61 pci/pcmcia support"
> > - depends on RT2X00 && PCI
> > + depends on PCI
> > select RT2X00_LIB_PCI
> > select RT2X00_LIB_FIRMWARE
> > select EEPROM_93CX6
> > @@ -97,7 +96,7 @@ config RT61PCI_RFKILL
> > =20
> > config RT2500USB
> > tristate "Ralink rt2500 usb support"
> > - depends on RT2X00 && USB
> > + depends on USB
> > select RT2X00_LIB_USB
> > ---help---
> > This is an experimental driver for the Ralink rt2500 wireless c=
hip.
> > @@ -106,7 +105,7 @@ config RT2500USB
> > =20
> > config RT73USB
> > tristate "Ralink rt73 usb support"
> > - depends on RT2X00 && USB
> > + depends on USB
> > select RT2X00_LIB_USB
> > select RT2X00_LIB_FIRMWARE
> > ---help---
> > @@ -128,3 +127,4 @@ config RT2X00_DEBUG
> > ---help---
> > Enable debugging output for all rt2x00 modules
> > =20
> > +endif
---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Rt2400-devel] [PATCH] wireless: rt2x00: fix driver menu indenting
2008-03-05 6:00 ` Randy Dunlap
@ 2008-03-05 18:11 ` John W. Linville
0 siblings, 0 replies; 4+ messages in thread
From: John W. Linville @ 2008-03-05 18:11 UTC (permalink / raw)
To: Randy Dunlap
Cc: Ivo van Doorn, rt2400-devel, linux-wireless, Michael Büker,
linux-kernel, akpm
On Tue, Mar 04, 2008 at 10:00:29PM -0800, Randy Dunlap wrote:
> On Sun, 10 Feb 2008 20:03:25 +0100 Ivo van Doorn wrote:
>=20
> > On Sunday 10 February 2008, Randy Dunlap wrote:
> > > On Sat, 9 Feb 2008 16:23:06 +0100 Michael B=FCker wrote:
> > >=20
> > > > 2) When selecting "Ralink driver support" (CONFIG_RT2X00), the =
accompanying=20
> > > > drivers (CONFIG_RT2400PCI, CONFIG_RT61PC, ...) appear unindente=
d. They should=20
> > > > be indented by four spaces.
> > >=20
> > > Yes, patch is below.
> > >=20
> > > ---
> > > From: Randy Dunlap <randy.dunlap@oracle.com>
> > >=20
> > > Michael B=FCker <m.bueker@berlin.de> reports that the RT2x00 driv=
ers
> > > are not indented as they should be, so use proper dependencies to=
make
> > > them be indented as expected.
> > >=20
> > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> >=20
> > Ack-by: Ivo van Doorn <IvDoorn@gmail.com>
> >=20
> > ---
> > John,
> > Could you push this directly into wireless-2.6 and probably upstrea=
m as well.
> >=20
> > Thanks.
> >=20
> > Ivo
>=20
> John, do you have this patch queued somewhere?
It is in net-2.6.26.
commit 0d84d78db5bad848e385cbb1e4ae2ea1f5f27641
Author: Randy Dunlap <randy.dunlap@oracle.com>
Date: Sun Feb 10 10:52:52 2008 -0800
wireless: rt2x00: fix driver menu indenting
Michael B=FCker <m.bueker@berlin.de> reports that the RT2x00 driver=
s
are not indented as they should be, so use proper dependencies to m=
ake
them be indented as expected.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Ack-by: Ivo van Doorn <IvDoorn@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Hth!
John
--=20
John W. Linville
linville@tuxdriver.com
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-03-05 18:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200802091623.06504.m.bueker@berlin.de>
2008-02-10 18:52 ` [PATCH] wireless: rt2x00: fix driver menu indenting Randy Dunlap
2008-02-10 19:03 ` [Rt2400-devel] " Ivo van Doorn
2008-03-05 6:00 ` Randy Dunlap
2008-03-05 18:11 ` John W. Linville
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).