From: Ivo van Doorn <ivdoorn@gmail.com>
To: Franz Apeltauer <franz.apeltauer@gmx.at>
Cc: "Luis R. Rodriguez" <mcgrof@gmail.com>, linux-wireless@vger.kernel.org
Subject: Re: 2 compile errors: rt2x00firmware.c and mesh.c
Date: Mon, 10 Mar 2008 23:21:35 +0100 [thread overview]
Message-ID: <200803102321.35909.IvDoorn@gmail.com> (raw)
In-Reply-To: <47D5AAFC.80401@gmx.at>
On Monday 10 March 2008, Franz Apeltauer wrote:
> Luis R. Rodriguez schrieb:
> >> b) Test on a PC with MSI PC54G2 ... RaLink rt2500
> >
> > You can test this now, I've enabled rt2x00 drivers by fixing
> > dependencies on config.mk. Forced re-generation of new tarball based
> > on latest updates too.
> >
> > Luis
>
> Loaded today's tarball (10.3.).
> The "redefinition of rt2x00lib_load_firmware" error is back.
>
> I believe, that there should be 2 additional lines in rt2x00firmware.c:
> a) line #115, before "int rt2x00lib_load_firmware":
> #ifdef CONFIG_RT2X00_LIB_FIRMWARE
> b) at the end of the file:
> #endif /* CONFIG_RT2X00_LIB_FIRMWARE */
> to be consistent with #ifdef/#else/#endif in rt2x00lib.h lines 124, 127,
> 135.
> Then it compiles fine. install, unload, load.
> ... and now I see wlan0 and wmaster0! Yippee!
How about not linking rt2x00firmware.c at all when RT2X00_LIB_FIRMWARE
is not set? That should be a clean solution that can be made in the Makefile...
Ivo
next prev parent reply other threads:[~2008-03-10 22:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-02 23:42 2 compile errors: rt2x00firmware.c and mesh.c Franz Apeltauer
2008-03-03 0:32 ` Johannes Berg
2008-03-03 3:52 ` Luis R. Rodriguez
2008-03-05 23:12 ` Franz Apeltauer
2008-03-05 23:15 ` Johannes Berg
2008-03-05 23:25 ` Franz Apeltauer
2008-03-05 23:34 ` Johannes Berg
2008-03-10 23:09 ` Franz Apeltauer
2008-03-08 2:59 ` Luis R. Rodriguez
2008-03-10 21:41 ` Franz Apeltauer
2008-03-10 22:21 ` Ivo van Doorn [this message]
2008-03-10 23:33 ` Luis R. Rodriguez
2008-03-11 0:07 ` Franz Apeltauer
2008-03-11 1:26 ` Luis R. Rodriguez
2008-03-11 20:06 ` Hauke Mehrtens
2008-03-11 21:24 ` Luis R. Rodriguez
2008-03-11 22:14 ` Franz Apeltauer
2008-03-11 22:22 ` Ivo van Doorn
2008-03-11 23:01 ` Franz Apeltauer
2008-03-11 23:09 ` Ivo van Doorn
2008-03-16 0:33 ` Franz Apeltauer
2008-03-17 17:12 ` Luis R. Rodriguez
2008-03-03 9:37 ` Ivo Van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803102321.35909.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=franz.apeltauer@gmx.at \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).