From: Holger Schurig <hs4233@mail.mn-solutions.de>
To: libertas-dev@lists.infradead.org
Cc: linux-wireless@vger.kernel.org, Dan Williams <dcbw@redhat.com>,
"John W. Linville" <linville@tuxdriver.com>
Subject: [PATCH] libertas: convert GET_LOG to a direct command
Date: Thu, 13 Mar 2008 09:48:36 +0100 [thread overview]
Message-ID: <200803130948.36528.hs4233@mail.mn-solutions.de> (raw)
Now uses __lbs_cmd() to get the "log" (it's actually more a
snapshot of various counters, not a sequential log).
Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
----
While looking here, I saw that that there is an imbalance on
populating priv->logmsg (via lbs_get_log() and it's usage.
lbs_get_log() is called twice:
* in assoc.c after a successful association
* in wext.c, lbs_get_wireless_stats()
however, priv->logmsg is only used once:
* in wext.c, lbs_get_wireless_stats(), to populate
priv->wstats.discard.*
However, the usage in wext.c happens BEFORE the call to
lbs_get_log(), so lbs_get_wireless_stats() actually works with
old data. This seems strange ...
Does anybody know if this was intended behavior? If not, I'd
kill the calls to lbs_get_log() in assoc.c and move the other
one to line 882 of wext.c.
next reply other threads:[~2008-03-13 8:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-13 8:48 Holger Schurig [this message]
2008-03-13 8:49 ` [PATCH] libertas: convert GET_LOG to a direct command Holger Schurig
2008-03-13 9:09 ` Holger Schurig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803130948.36528.hs4233@mail.mn-solutions.de \
--to=hs4233@mail.mn-solutions.de \
--cc=dcbw@redhat.com \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox