[PATCH 1/7] drivers/net/wireless/b43/lo.c: remove unused variable

[PATCH 1/7] drivers/net/wireless/b43/lo.c: remove unused variable

[Julia Lawall]

From: Julia Lawall <julia@diku.dk>

The variable trsw_rx is initialized but never used otherwise.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
identifier i;
constant C;
@@

(
extern T i;
|
- T i;
  <+... when != i
- i = C;
  ...+>
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
---
 drivers/net/wireless/b43/lo.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff -u -p a/drivers/net/wireless/b43/lo.c b/drivers/net/wireless/b43/lo.c
--- a/drivers/net/wireless/b43/lo.c	2008-03-12 14:13:14.000000000 +0100
+++ b/drivers/net/wireless/b43/lo.c	2008-03-15 15:56:58.000000000 +0100
@@ -493,15 +493,12 @@ static void lo_measure_gain_values(struc
 		max_rx_gain = 0;
 
 	if (has_loopback_gain(phy)) {
-		int trsw_rx = 0;
 		int trsw_rx_gain;
 
 		if (use_trsw_rx) {
 			trsw_rx_gain = phy->trsw_rx_gain / 2;
-			if (max_rx_gain >= trsw_rx_gain) {
+			if (max_rx_gain >= trsw_rx_gain)
 				trsw_rx_gain = max_rx_gain - trsw_rx_gain;
-				trsw_rx = 0x20;
-			}
 		} else
 			trsw_rx_gain = max_rx_gain;
 		if (trsw_rx_gain < 9) {

Re: [PATCH 1/7] drivers/net/wireless/b43/lo.c: remove unused variable

[Michael Buesch]

On Saturday 15 March 2008 17:02:36 Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
> 
> The variable trsw_rx is initialized but never used otherwise.

You get a NACK for now. Most likely this is a bug and the variable
does actually have to be used somewhere. I'll take a look at it.

> Signed-off-by: Julia Lawall <julia@diku.dk>
> ---
>  drivers/net/wireless/b43/lo.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff -u -p a/drivers/net/wireless/b43/lo.c b/drivers/net/wireless/b43/lo.c
> --- a/drivers/net/wireless/b43/lo.c	2008-03-12 14:13:14.000000000 +0100
> +++ b/drivers/net/wireless/b43/lo.c	2008-03-15 15:56:58.000000000 +0100
> @@ -493,15 +493,12 @@ static void lo_measure_gain_values(struc
>  		max_rx_gain = 0;
>  
>  	if (has_loopback_gain(phy)) {
> -		int trsw_rx = 0;
>  		int trsw_rx_gain;
>  
>  		if (use_trsw_rx) {
>  			trsw_rx_gain = phy->trsw_rx_gain / 2;
> -			if (max_rx_gain >= trsw_rx_gain) {
> +			if (max_rx_gain >= trsw_rx_gain)
>  				trsw_rx_gain = max_rx_gain - trsw_rx_gain;
> -				trsw_rx = 0x20;
> -			}
>  		} else
>  			trsw_rx_gain = max_rx_gain;
>  		if (trsw_rx_gain < 9) {


-- 
Greetings Michael.