From: Michael Buesch <mb@bu3sch.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Greg KH <greg@kroah.com>,
heiko.carstens@de.ibm.com, stern@rowland.harvard.edu,
hmh@hmh.eng.br, david-b@pacbell.net, rpurdie@rpsys.net,
linux-kernel@vger.kernel.org, mingo@elte.hu,
geert@linux-m68k.org, netdev@vger.kernel.org,
schwidefsky@de.ibm.com, linux-usb@vger.kernel.org,
linux-wireless@vger.kernel.org, video4linux-list@redhat.com,
stefanr@s5r6.in-berlin.de, lm-sensors@lm-sensors.org
Subject: Re: use of preempt_count instead of in_atomic() at leds-gpio.c
Date: Fri, 21 Mar 2008 21:16:48 +0100 [thread overview]
Message-ID: <200803212116.49462.mb@bu3sch.de> (raw)
In-Reply-To: <20080321125950.a5b38bda.akpm@linux-foundation.org>
On Friday 21 March 2008 20:59:50 Andrew Morton wrote:
> They could of course be switched to using
> kmalloc(GFP_ATOMIC)+memcpy()+schedule_task(). That's rather slow, but this
> is not a performance-sensitive area. But more seriously, this could lead
> to messages getting lost from a dying machine.
Well, IMO drivers that need to sleep to transmit some data (to whatever,
the screen or something) are not useful for debugging a crashing kernel anyway.
Or how high is the possibility that it'd survive the actual sleep in the
memory allocation? I'd say almost zero.
So that schedule_task() is not that bad.
--
Greetings Michael.
next prev parent reply other threads:[~2008-03-21 20:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080316184349.GA28543@khazad-dum.debian.net>
[not found] ` <200803161246.23909.david-b@pacbell.net>
[not found] ` <20080318001429.896acf51.akpm@linux-foundation.org>
[not found] ` <20080320225612.GB20788@khazad-dum.debian.net>
[not found] ` <20080320164741.734e838c.akpm@linux-foundation.org>
[not found] ` <20080321003604.GC20788@khazad-dum.debian.net>
2008-03-21 1:08 ` use of preempt_count instead of in_atomic() at leds-gpio.c Andrew Morton
2008-03-21 1:31 ` Alan Stern
2008-03-21 1:36 ` Michael Buesch
2008-03-21 2:27 ` Andrew Morton
2008-03-21 3:07 ` Alan Stern
2008-03-21 3:17 ` Andrew Morton
2008-03-21 13:47 ` Heiko Carstens
2008-03-21 16:54 ` Greg KH
2008-03-21 19:59 ` Andrew Morton
2008-03-21 20:16 ` Michael Buesch [this message]
2008-03-21 20:20 ` Michael Buesch
2008-03-21 9:21 ` Stefan Richter
2008-03-21 9:27 ` Stefan Richter
2008-03-21 12:37 ` Henrique de Moraes Holschuh
2008-03-21 13:16 ` Stefan Richter
2008-03-22 11:29 ` Stefan Richter
2008-03-21 17:04 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803212116.49462.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=geert@linux-m68k.org \
--cc=greg@kroah.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hmh@hmh.eng.br \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=schwidefsky@de.ibm.com \
--cc=stefanr@s5r6.in-berlin.de \
--cc=stern@rowland.harvard.edu \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).