linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ivo van Doorn <ivdoorn@gmail.com>
To: rt2400-devel@lists.sourceforge.net
Cc: linux-wireless@vger.kernel.org
Subject: Re: rt2x00: LED classes
Date: Mon, 24 Mar 2008 17:20:49 +0100	[thread overview]
Message-ID: <200803241720.49887.IvDoorn@gmail.com> (raw)
In-Reply-To: <200803212146.34141.IvDoorn@gmail.com>

Hi,

> I must admit that I don't know if LED triggers work
> in non-sleepable context by design or if it depends
> on the calling trigger....

On inspection of led_trigger_event() it seems to grab
a read_lock before calling the driver.
This means that USB drivers cannot use LED triggers.

I will see if I can simulate the behavior differently
where LED classes are still used but rt2x00 implements
its own version of LED triggers. Most likely this will result
in rt2x00 not be using the triggers provided by mac80211
for any of the drivers.

For the time being LED support for rt2500usb and rt73usb
will be disabled with CONFIG_BROKEN. A better solution will
hopefully be ready for 2.6.27.

Ivo

      reply	other threads:[~2008-03-24 16:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-21 20:46 rt2x00: LED classes Ivo van Doorn
2008-03-24 16:20 ` Ivo van Doorn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803241720.49887.IvDoorn@gmail.com \
    --to=ivdoorn@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rt2400-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).