From: "John W. Linville" <linville@tuxdriver.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: silently accept deletion of non-existant key
Date: Tue, 25 Mar 2008 12:37:51 -0400 [thread overview]
Message-ID: <20080325163751.GA19318@tuxdriver.com> (raw)
In-Reply-To: <1206462125.16475.303.camel@johannes.berg>
On Tue, Mar 25, 2008 at 05:22:05PM +0100, Johannes Berg wrote:
>
> On Tue, 2008-03-25 at 11:43 -0400, John W. Linville wrote:
> > From: John W. Linville <linville@linville-t41.local>
> >
> > Otherwise, 'iwconfig wlan0 key off' with no key set results in:
> >
> > Error for wireless request "Set Encode" (8B2A) :
> > SET failed on device wlan0 ; No such file or directory.
>
> And what is the problem with us telling iwconfig that there was no key?
> You should argue for iwconfig ignoring that particular problem, but I
> don't think we should do so in the kernel.
Why is it a problem? How does it hurt anything? How is it useful
to return an error?
FWIW, other drivers seem to accept it. I don't see why we need to
complain.
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2008-03-25 17:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-25 15:43 [PATCH] mac80211: silently accept deletion of non-existant key John W. Linville
2008-03-25 16:22 ` Johannes Berg
2008-03-25 16:37 ` John W. Linville [this message]
2008-03-25 17:12 ` Michael Buesch
2008-03-25 17:36 ` John W. Linville
2008-03-26 12:47 ` Johannes Berg
2008-03-26 15:18 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080325163751.GA19318@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).