Re: [PATCH] mac80211: use hardware flags for signal/noise units

[bruno randolf <bruno@thinktube.com>]

On Thursday 27 March 2008 21:47:43 Johannes Berg wrote:
> On Wed, 2008-03-26 at 21:30 +0900, Bruno Randolf wrote:
> > trying to clean up the signal/noise mess. the previous code in mac80211
> > did not have much definition of what units of signal and noise were
> > provided and used weird implicit mechanisms from the wireless extensions.
> >
> > introduce hardware capability flags to let the hardware specify if it can
> > provide signal and noise level values and which units it can provide:
> >
> >   IEEE80211_HW_SIGNAL_UNSPEC - unspecified, unknown, hw specific
> >   IEEE80211_HW_SIGNAL_DB     - dB difference to unspecified reference
> > point IEEE80211_HW_SIGNAL_DBM    - dBm, difference to 1mW
> >
> >   IEEE80211_HW_NOISE_DBM     - dBm, difference to 1mW
> >
> > also clean up the misleading and confusing names which were used for
> > signal, noise and qual before.
>
> I have to admit to not particularly caring about these things, so if
> you're willing to accept responsibility for all breakage I'm ok with the
> patch going in :)

well, i'm going to - for whatever that means :)

i have compile tested the current patch with all mac80211 based drivers, i 
believe and function tested with ath5k and iwl4965 - but lets give the driver 
authors some more time for feedback and review. also i'd like to integrate 
jean's suggestion that unspec doesn't have to be linear.

bruno