linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ivo van Doorn <ivdoorn@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Bas Hulsken <bhulsken@hotmail.com>, linux-wireless@vger.kernel.org
Subject: Re: rt2500pci, infinite calls to rt2x00mc_configure_filter
Date: Mon, 31 Mar 2008 14:51:22 +0200	[thread overview]
Message-ID: <200803311451.23388.IvDoorn@gmail.com> (raw)
In-Reply-To: <1206964876.5468.12.camel@johannes.berg>

Hi,

> Thanks for helping debug this. I haven't had a chance to run hostapd
> again, been far too busy. As it stands, I'm not sure when I can possibly
> get to that.
> 
> > > rt2500pci filter_flags: 2
> > > rt2500pci MAC changed: 00:0c:f6:14:05:19
> > 
> > Packet filter flags of 2 sounds a bit restrictive.
> > 
> > Johannes, for Master mode shouldn't the following flags be set as well:
> > FIF_PROMISC_IN_BSS
> > FIF_CONTROL
> > 
> > Or should the driver enable those automatically when master mode is enabled?
> 
> The driver most definitely shouldn't do anything, but neither of those
> flags should be needed. In a BSS, all frames from the stations are
> addressed to the BSS-MAC, i.e. to the AP, so the regular MAC filter
> should allow them through without any sort of promisc. And control
> frames aren't needed, those are just ack/cts/... frames.

Ok, I think I found the problem. The packet filter in all Ralink devices have a
TODS filter. Currently I had this only enabled when FIF_PROMISC_IN_BSS was set.
I'll change this to a check that determines if master mode is enabled.

Ivo

  reply	other threads:[~2008-03-31 12:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-29 14:34 rt2500pci, infinite calls to rt2x00mc_configure_filter Bas Hulsken
2008-03-29 14:53 ` Ivo van Doorn
2008-03-29 16:42   ` Bas Hulsken
2008-03-29 17:01     ` Ivo van Doorn
2008-03-29 23:45       ` Adam Baker
2008-03-30 13:15         ` Bas Hulsken
2008-03-30 13:27           ` Ivo van Doorn
2008-03-30 16:32             ` Bas Hulsken
2008-03-30 16:49               ` Mattias Nissler
2008-03-31 12:01       ` Johannes Berg
2008-03-31 12:51         ` Ivo van Doorn [this message]
2008-03-31 12:56           ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803311451.23388.IvDoorn@gmail.com \
    --to=ivdoorn@gmail.com \
    --cc=bhulsken@hotmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).