From: Holger Schurig <hs4233@mail.mn-solutions.de>
To: Marcelo Tosatti <marcelo@kvack.org>
Cc: Dan Williams <dcbw@redhat.com>,
linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
libertas-dev@lists.infradead.org
Subject: Re: [PATCH, take 3] libertas: convert RSSI to a direct command
Date: Tue, 1 Apr 2008 08:48:48 +0200 [thread overview]
Message-ID: <200804010848.48789.hs4233@mail.mn-solutions.de> (raw)
In-Reply-To: <20080401031530.GA14633@dmt>
> Won't this call block? You can't block in the get_wireless
> handler (it holds the rtnl lock). See wext_handle_ioctl.
Yes, this blocks.
So you mean that when I cannot get a current RSSI value at this
time I have to re-use some old value? The older code used this
schema:
when associated:
get rssi in-the-background and store it away
when AdHoc network created:
get rssi in-the-background and store it away
in lbs_get_wireless_stats()
use stored away RSSI value
get rssi in-the-background and store it away
The problem with this scheme is that the "stored away RSSI" might
be an hour ago. So the first call to to get the wireless stats
gives you back a blatant lie.
Do you see a way around this?
next prev parent reply other threads:[~2008-04-01 6:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 9:21 [PATCH, take 3] libertas: convert RSSI to a direct command Holger Schurig
2008-03-27 21:24 ` Dan Williams
2008-04-01 3:15 ` Marcelo Tosatti
2008-04-01 6:48 ` Holger Schurig [this message]
[not found] ` <200804010943.56075.marc.pignat@hevs.ch>
2008-04-01 13:30 ` Holger Schurig
2008-04-10 15:43 ` Marcelo Tosatti
2008-04-10 15:47 ` Johannes Berg
2008-04-10 19:08 ` Marcelo Tosatti
2008-04-11 12:17 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804010848.48789.hs4233@mail.mn-solutions.de \
--to=hs4233@mail.mn-solutions.de \
--cc=dcbw@redhat.com \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=marcelo@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).