From: Randy Dunlap <randy.dunlap@oracle.com>
To: Michael Buesch <mb@bu3sch.de>
Cc: John Linville <linville@tuxdriver.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ssb: Fix build for non-PCIhost
Date: Wed, 2 Apr 2008 08:33:43 -0700 [thread overview]
Message-ID: <20080402083343.02de39c0.randy.dunlap@oracle.com> (raw)
In-Reply-To: <200804021703.27817.mb@bu3sch.de>
On Wed, 2 Apr 2008 17:03:26 +0200 Michael Buesch wrote:
> This fixes a build error when PCMCIA-host support is built,
> but PCI-host support is disabled.
> Hell, who on earth would use such a weird configuration. :D
>
> drivers/built-in.o: In function `ssb_attr_sprom_store':
> (.text+0x1c4b79): undefined reference to `ssb_devices_freeze'
> drivers/built-in.o: In function `ssb_attr_sprom_store':
> (.text+0x1c4bb3): undefined reference to `ssb_devices_thaw'
> make[1]: *** [.tmp_vmlinux1] Error 1
>
> Signed-off-by: Michael Buesch <mb@bu3sch.de>
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
>
> John, please apply this to 2.6.26
>
>
> Index: wireless-testing/drivers/ssb/main.c
> ===================================================================
> --- wireless-testing.orig/drivers/ssb/main.c 2008-03-21 21:41:31.000000000 +0100
> +++ wireless-testing/drivers/ssb/main.c 2008-04-02 16:50:16.000000000 +0200
> @@ -202,7 +202,7 @@ out:
> return err;
> }
>
> -#ifdef CONFIG_SSB_PCIHOST
> +#ifdef CONFIG_SSB_SPROM
> int ssb_devices_freeze(struct ssb_bus *bus)
> {
> struct ssb_device *dev;
> @@ -288,7 +288,7 @@ int ssb_devices_thaw(struct ssb_bus *bus
>
> return 0;
> }
> -#endif /* CONFIG_SSB_PCIHOST */
> +#endif /* CONFIG_SSB_SPROM */
>
> static void ssb_device_shutdown(struct device *dev)
> {
>
>
> --
---
~Randy
prev parent reply other threads:[~2008-04-02 15:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080401175230.9ffe75cf.sfr@canb.auug.org.au>
[not found] ` <20080401092119.3cb214b1.randy.dunlap@oracle.com>
2008-04-02 15:03 ` [PATCH] ssb: Fix build for non-PCIhost Michael Buesch
2008-04-02 15:33 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080402083343.02de39c0.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox