linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Buesch <mb@bu3sch.de>
To: bcm43xx-dev@lists.berlios.de
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
	John Linville <linville@tuxdriver.com>,
	wireless <linux-wireless@vger.kernel.org>,
	KURT PETERS <peterskurt@msn.com>
Subject: Re: [PATCH] b43legacy: Partial Fix for Range issue
Date: Thu, 3 Apr 2008 20:50:38 +0200	[thread overview]
Message-ID: <200804032050.38774.mb@bu3sch.de> (raw)
In-Reply-To: <47F5242D.80404@lwfinger.net>

On Thursday 03 April 2008 20:38:37 Larry Finger wrote:
> When the mac80211 channel tables were recently changed,
> the power_level member was removed. As a result, the value
> passed to b43legacy in conf->power_level became zero. This
> value is transferred to phy->power_level and used in calculating
> the desired TX power, which thus became zero. This patch does not
> fix all the power problems with b43legacy, but it will be needed
> anyway.
> 
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
> 
> John,
> 
> This is 2.6.25 material.
> 
> Larry
> 
> 
> Index: wireless-testing/drivers/net/wireless/b43legacy/main.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/b43legacy/main.c
> +++ wireless-testing/drivers/net/wireless/b43legacy/main.c
> @@ -127,6 +127,7 @@ static struct ieee80211_rate __b43legacy
>   	{							\
>   		.center_freq	= (_freq),			\
>   		.hw_value	= (_chanid),			\
> +		.max_power	= 0x14,				\
>   	}
>   static struct ieee80211_channel b43legacy_bg_chantable[] = {
>   	CHANTAB_ENT(1, 2412),
> 
> 

In b43 I set this value to 30.
I dunno what the real HW upper limit is, so I set it so something
that's way above the actual value mac80211 will ever try anyway (because
mac80211 won't try illegal rates, if implemented correctly).

-- 
Greetings Michael.

  reply	other threads:[~2008-04-03 18:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <BAY103-F373BE8D28C2F2A21BC15E0D8F70@phx.gbl>
     [not found] ` <200804031719.44026.mb@bu3sch.de>
2008-04-03 18:38   ` [PATCH] b43legacy: Partial Fix for Range issue Larry Finger
2008-04-03 18:50     ` Michael Buesch [this message]
2008-04-03 20:10       ` Larry Finger
2008-04-03 19:32     ` [PATCH] cfg80211: default to regulatory max power for channel John W. Linville
2008-04-03 20:08       ` Michael Buesch
2008-04-03 21:01       ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200804032050.38774.mb@bu3sch.de \
    --to=mb@bu3sch.de \
    --cc=Larry.Finger@lwfinger.net \
    --cc=bcm43xx-dev@lists.berlios.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=peterskurt@msn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).