From: Michael Buesch <mb@bu3sch.de>
To: bcm43xx-dev@lists.berlios.de
Cc: Stefano Brivio <stefano.brivio@polimi.it>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] b43legacy: fix bcm4303 crash
Date: Sun, 6 Apr 2008 17:20:02 +0200 [thread overview]
Message-ID: <200804061720.02381.mb@bu3sch.de> (raw)
In-Reply-To: <20080406170507.16992935@polimi.it>
On Sunday 06 April 2008 17:05:07 Stefano Brivio wrote:
> This fixes an hard crash which happened upon driver loading on bcm4303 rev.
> 2 devices.
>
> Signed-off-by: Stefano Brivio <stefano.brivio@polimi.it>
ACK
> ---
> John, this is for 2.6.26.
Why not 2.6.25?
> ---
> diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
> index e123719..4bc0e8b 100644
> --- a/drivers/ssb/main.c
> +++ b/drivers/ssb/main.c
> @@ -1101,6 +1101,12 @@ int ssb_bus_may_powerdown(struct ssb_bus *bus)
> goto out;
>
> cc = &bus->chipco;
> +
> + if (!cc->dev)
> + goto out;
> + if (cc->dev->id.revision < 5)
> + goto out;
> +
> ssb_chipco_set_clockmode(cc, SSB_CLKMODE_SLOW);
> err = ssb_pci_xtal(bus, SSB_GPIO_XTAL | SSB_GPIO_PLL, 0);
> if (err)
>
>
> --
> Ciao
> Stefano
> _______________________________________________
> Bcm43xx-dev mailing list
> Bcm43xx-dev@lists.berlios.de
> https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
>
>
--
Greetings Michael.
next prev parent reply other threads:[~2008-04-06 15:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-06 15:05 [PATCH] b43legacy: fix bcm4303 crash Stefano Brivio
2008-04-06 15:20 ` Michael Buesch [this message]
2008-04-06 15:54 ` Stefano Brivio
2008-04-06 15:29 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804061720.02381.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=stefano.brivio@polimi.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).