linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ssb-pcicore: Remove b44 TPS flag workaround
@ 2008-04-08  8:31 Michael Buesch
  0 siblings, 0 replies; only message in thread
From: Michael Buesch @ 2008-04-08  8:31 UTC (permalink / raw)
  To: John Linville; +Cc: bcm43xx-dev, linux-wireless, Larry Finger

Now that we fixed the TPS flag assignment in commit
JOHN, INSERT COMMIT ID HERE
we don't need the workaround for the bcm44xx chip anymore.

Signed-off-by: Michael Buesch <mb@bu3sch.de>

---

John, please apply to 2.6.26.
But please insert the commit ID of
"[PATCH] ssb-pcicore: Fix IRQ TPS flag handling" into the commit text first.


Index: wireless-testing/drivers/ssb/driver_pcicore.c
===================================================================
--- wireless-testing.orig/drivers/ssb/driver_pcicore.c	2008-04-08 00:40:06.000000000 +0200
+++ wireless-testing/drivers/ssb/driver_pcicore.c	2008-04-08 00:41:00.000000000 +0200
@@ -559,21 +559,15 @@ int ssb_pcicore_dev_irqvecs_enable(struc
 		if (err)
 			goto out;
 	} else {
 		u32 intvec;
 
 		intvec = ssb_read32(pdev, SSB_INTVEC);
-		if ((bus->chip_id & 0xFF00) == 0x4400) {
-			/* Workaround: On the BCM44XX the BPFLAG routing
-			 * bit is wrong. Use a hardcoded constant. */
-			intvec |= 0x00000002;
-		} else {
-			tmp = ssb_read32(dev, SSB_TPSFLAG);
-			tmp &= SSB_TPSFLAG_BPFLAG;
-			intvec |= (1 << tmp);
-		}
+		tmp = ssb_read32(dev, SSB_TPSFLAG);
+		tmp &= SSB_TPSFLAG_BPFLAG;
+		intvec |= (1 << tmp);
 		ssb_write32(pdev, SSB_INTVEC, intvec);
 	}
 
 	/* Setup PCIcore operation. */
 	if (pc->setup_done)
 		goto out;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-04-08  8:32 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-08  8:31 [PATCH] ssb-pcicore: Remove b44 TPS flag workaround Michael Buesch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).