From: Marcelo Tosatti <mtosatti@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Holger Schurig <hs4233@mail.mn-solutions.de>,
Marcelo Tosatti <marcelo@kvack.org>,
Dan Williams <dcbw@redhat.com>,
linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
libertas-dev@lists.infradead.org
Subject: Re: [PATCH, take 3] libertas: convert RSSI to a direct command
Date: Thu, 10 Apr 2008 16:08:58 -0300 [thread overview]
Message-ID: <20080410190858.GA8969@dmt> (raw)
In-Reply-To: <1207842441.13354.9.camel@johannes.berg>
On Thu, Apr 10, 2008 at 05:47:21PM +0200, Johannes Berg wrote:
> On Thu, 2008-04-10 at 12:43 -0300, Marcelo Tosatti wrote:
> > On Tue, Apr 01, 2008 at 08:48:48AM +0200, Holger Schurig wrote:
> > > > Won't this call block? You can't block in the get_wireless
> > > > handler (it holds the rtnl lock). See wext_handle_ioctl.
> > >
> > > Yes, this blocks.
> > >
> > > So you mean that when I cannot get a current RSSI value at this
> > > time I have to re-use some old value?
> >
> > All I mean is that get_wireless_stats should not schedule() because it
> > holds the rtnl_lock. You get ugly hangs doing that.
>
> Of course you can schedule with the rtnl held. It's a mutex, after all.
True, my bad. The problem is:
dev_seq_start
read_lock(&dev_base_lock)
wireless_seq_show
wireless_seq_printf_stats
get_wireless_stats
dev->wireless_handlers->get_wireless_stats
next prev parent reply other threads:[~2008-04-10 19:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 9:21 [PATCH, take 3] libertas: convert RSSI to a direct command Holger Schurig
2008-03-27 21:24 ` Dan Williams
2008-04-01 3:15 ` Marcelo Tosatti
2008-04-01 6:48 ` Holger Schurig
[not found] ` <200804010943.56075.marc.pignat@hevs.ch>
2008-04-01 13:30 ` Holger Schurig
2008-04-10 15:43 ` Marcelo Tosatti
2008-04-10 15:47 ` Johannes Berg
2008-04-10 19:08 ` Marcelo Tosatti [this message]
2008-04-11 12:17 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080410190858.GA8969@dmt \
--to=mtosatti@redhat.com \
--cc=dcbw@redhat.com \
--cc=hs4233@mail.mn-solutions.de \
--cc=johannes@sipsolutions.net \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=marcelo@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).