From: "John W. Linville" <linville@tuxdriver.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "Chatre, Reinette" <reinette.chatre@intel.com>,
Meelis Roos <mroos@linux.ee>,
linux-wireless@vger.kernel.org, "Zhu, Yi" <yi.zhu@intel.com>
Subject: Re: iwlwifi integer overflow warnings
Date: Fri, 11 Apr 2008 08:27:32 -0400 [thread overview]
Message-ID: <20080411122732.GA4192@tuxdriver.com> (raw)
In-Reply-To: <1207916204.13354.63.camel@johannes.berg>
On Fri, Apr 11, 2008 at 02:16:44PM +0200, Johannes Berg wrote:
>
> > > drivers/net/wireless/iwlwifi/iwl3945-base.c: In function
> > > 'iwl3945_enqueue_hcmd':
> > > drivers/net/wireless/iwlwifi/iwl3945-base.c:719: warning: integer
> > > overflow in expression drivers/net/wireless/iwlwifi/iwl-3945.c: In
> > > function 'iwl3945_add_radiotap':
> > > drivers/net/wireless/iwlwifi/iwl-3945.c:326: warning: integer
> > > overflow in expression drivers/net/wireless/iwlwifi/iwl4965-base.c:
> > > In function 'iwl4965_enqueue_hcmd':
> > > drivers/net/wireless/iwlwifi/iwl4965-base.c:723: warning: integer
> > > overflow in expression drivers/net/wireless/iwlwifi/iwl-4965.c: In
> > > function 'iwl4965_add_radiotap':
> > > drivers/net/wireless/iwlwifi/iwl-4965.c:3617: warning: integer
> > > overflow in expression
> > >
> >
> > (adding Johannes and John)
> >
> > These problems have been fixed by Johannes with his patch "iwlwifi:fix
> > some warnings". If this is an issue in 2.6.25 then that kernel may take
> > this patch to address the problem.
>
> That patch never was applied though and Tomas had reservations. I didn't
> have time to look at it again.
Actually, I factored-out the parts Tomas didn't like and applied it.
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2008-04-11 12:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 8:26 iwlwifi integer overflow warnings Meelis Roos
2008-04-10 20:29 ` Chatre, Reinette
2008-04-11 12:16 ` Johannes Berg
2008-04-11 12:27 ` John W. Linville [this message]
2008-04-11 14:55 ` Chatre, Reinette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080411122732.GA4192@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mroos@linux.ee \
--cc=reinette.chatre@intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox