Re: mac80211 hardware encryption

[Ivo van Doorn <ivdoorn@gmail.com>]

On Tuesday 15 April 2008, Johannes Berg wrote:
> 
> > > Not sure what was intention for hw_key_idx but currently there are assignment
> > > from key->conf.keyidx to hw_key_idx and visa versa.  keyidx is used
> > > for 802.11 key index [1..4]
> > > So it's quit risky to use it for something else
> > 
> > That souds like a bug in mac80211 then. hw_key_idx is for internal use for the driver,
> > and mac80211 should never expect the driver to set it to a particular value.
> 
> Yeah, that'd be a bug, and I can't find any such assignment. In fact,
> mac80211 doesn't contain any assignment to hw_key_idx or to a 1-4
> key_idx from hw_key_idx. Never mind the fact that the tx_control member
> could be called hw_key_idx as well...
> 
> In any case, for the problem at hand, I wouldn't mind increasing
> hw_key_idx to a u16 all the way through, or pass the key_conf pointer
> instead.

I'll create a patch that changes it to the key_conf pointer then,
that sounds like the safest option to allow changes to key_conf later.

Note that this change (either adding the key_conf pointer or the hw_key_idx to u16)
will cause ieee80211_tx_control to exceed the 48 bytes. So that will make it
harder to move it into the skb->cb array later.

Ivo