From: Jouni Malinen <j@w1.fi>
To: Tomas Winkler <tomasw@gmail.com>
Cc: Ivo van Doorn <ivdoorn@gmail.com>,
Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Subject: Re: mac80211 hardware encryption
Date: Wed, 16 Apr 2008 09:15:48 +0300 [thread overview]
Message-ID: <20080416061548.GH15053@jm.kir.nu> (raw)
In-Reply-To: <1ba2fa240804141139ua5f6f26k6920001ceb59443e@mail.gmail.com>
On Mon, Apr 14, 2008 at 09:39:00PM +0300, Tomas Winkler wrote:
> Not sure what was intention for hw_key_idx but currently there are assignment
> from key->conf.keyidx to hw_key_idx and visa versa. keyidx is used
> for 802.11 key index [1..4]
> So it's quit risky to use it for something else
hw_key_idx was supposed to be a value that the hardware driver assigns
for each key. This allows the driver to use suitable values that map
easily to whatever key table is used in the hardware/firmware. This is
_not_ same as 802.11 key index (0..3) and no code should made such an
assumption. Based on a quick search, I did not find any net/mac80211
code assigning key->conf.keyidx into hw_key_idx (or struct
ieee80211_tx_control::key_idx).
At least as far as the original design is concerned, hw_key_idx is
controlled by the hardware driver and it is only an internal identifier
for a specific hwaccel key.
--
Jouni Malinen PGP id EFC895FA
prev parent reply other threads:[~2008-04-16 6:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-05 17:31 mac80211 hardware encryption Ivo van Doorn
2008-04-06 16:44 ` Ivo van Doorn
2008-04-07 7:07 ` Jouni Malinen
2008-04-07 13:09 ` Johannes Berg
2008-04-07 13:34 ` Ivo van Doorn
2008-04-07 13:47 ` Johannes Berg
2008-04-07 14:10 ` Ivo van Doorn
2008-04-07 14:12 ` Johannes Berg
2008-04-07 14:26 ` Ivo van Doorn
2008-04-07 14:36 ` Johannes Berg
2008-04-07 14:45 ` Ivo van Doorn
2008-04-14 16:27 ` Ivo van Doorn
2008-04-14 18:39 ` Tomas Winkler
2008-04-14 21:07 ` Ivo van Doorn
2008-04-15 10:35 ` Johannes Berg
2008-04-15 15:17 ` Ivo van Doorn
2008-04-16 13:57 ` Johannes Berg
2008-04-17 10:14 ` Johannes Berg
2008-04-17 17:04 ` Ivo van Doorn
2008-04-15 15:55 ` Tomas Winkler
2008-04-16 6:15 ` Jouni Malinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080416061548.GH15053@jm.kir.nu \
--to=j@w1.fi \
--cc=ivdoorn@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=tomasw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).