Re: [PATCH v2] b43: Add fastpath to b43_mac_suspend()

[Michael Buesch <mb@bu3sch.de>]

On Wednesday 16 April 2008 20:36:39 Johannes Berg wrote:
> On Tue, 2008-04-15 at 21:13 +0200, Michael Buesch wrote:
> > This adds a fastpath for the common workloads to the
> > MAC suspend flushing.
> 
> 
> > @@ -2340,12 +2340,20 @@ static void b43_mac_suspend(struct b43_w
> >  		b43_power_saving_ctl_bits(dev, B43_PS_AWAKE);
> >  		b43_write32(dev, B43_MMIO_MACCTL,
> >  			    b43_read32(dev, B43_MMIO_MACCTL)
> >  			    & ~B43_MACCTL_ENABLED);
> >  		/* force pci to flush the write */
> >  		b43_read32(dev, B43_MMIO_MACCTL);
> > +		/* Finally wait for the microcode to flush the fifos. */
> 
> That comment is wrong, the ucode won't flush the FIFOs, it'll just go to
> sleep. If you want it to flush FIFOs you have to set a flush request bit
> somewhere (mac command I think), but you don't actually, you just don't
> want to have it processing stuff.

Ah yeah. Whatever. What was meant it it flushes everything from the host
point of view and goes to sleep. Feel free to remove that comment, John.
(simply remove the line from the patch before applying it).

-- 
Greetings Michael.