From: Ivo van Doorn <ivdoorn@gmail.com>
To: Michael Buesch <mb@bu3sch.de>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org,
Johannes Berg <johannes@sipsolutions.net>,
Jiri Slaby <jirislaby@gmail.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
Zhu Yi <yi.zhu@intel.com>
Subject: Re: [PATCH] mac80211: Replace ieee80211_tx_control->key_idx with ieee80211_key_conf
Date: Thu, 17 Apr 2008 17:56:51 +0200 [thread overview]
Message-ID: <200804171756.51480.IvDoorn@gmail.com> (raw)
In-Reply-To: <200804171729.34583.mb@bu3sch.de>
On Thursday 17 April 2008, Michael Buesch wrote:
> On Thursday 17 April 2008 17:28:29 Ivo van Doorn wrote:
> > diff --git a/drivers/net/wireless/b43/xmit.c b/drivers/net/wireless/b43/xmit.c
> > index 19aefbf..2ee19cf 100644
> > --- a/drivers/net/wireless/b43/xmit.c
> > +++ b/drivers/net/wireless/b43/xmit.c
> > @@ -235,7 +235,7 @@ int b43_generate_txhdr(struct b43_wldev *dev,
> >
> > plcp_fragment_len = fragment_len + FCS_LEN;
> > if (use_encryption) {
> > - u8 key_idx = (u16) (txctl->key_idx);
> > + u8 key_idx = (u16) (txctl->hw_key->hw_key_idx);
>
> Can we actually remove that bogus cast while we are at it? :)
>
> > struct b43_key *key;
> > int wlhdr_len;
> > size_t iv_len;
> > diff --git a/drivers/net/wireless/b43legacy/xmit.c b/drivers/net/wireless/b43legacy/xmit.c
> > index dcad249..ba50b68 100644
> > --- a/drivers/net/wireless/b43legacy/xmit.c
> > +++ b/drivers/net/wireless/b43legacy/xmit.c
> > @@ -232,7 +232,7 @@ static int generate_txhdr_fw3(struct b43legacy_wldev *dev,
> >
> > plcp_fragment_len = fragment_len + FCS_LEN;
> > if (use_encryption) {
> > - u8 key_idx = (u16)(txctl->key_idx);
> > + u8 key_idx = (u16)(txctl->hw_key->hw_key_idx);
>
> Same here.
Sure, updated patch on its way. :)
Ivo
next prev parent reply other threads:[~2008-04-17 15:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-17 15:28 [PATCH] mac80211: Replace ieee80211_tx_control->key_idx with ieee80211_key_conf Ivo van Doorn
2008-04-17 15:29 ` Michael Buesch
2008-04-17 15:56 ` Ivo van Doorn [this message]
2008-04-17 15:59 ` [PATCH v2] " Ivo van Doorn
2008-04-17 16:54 ` Johannes Berg
2008-04-17 17:23 ` [PATCH v3] " Ivo van Doorn
2008-04-17 17:26 ` Johannes Berg
2008-04-17 17:41 ` [PATCH v4] " Ivo van Doorn
2008-04-17 22:02 ` Johannes Berg
2008-04-18 16:56 ` Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804171756.51480.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=jirislaby@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).