From: Holger Schurig <hs4233@mail.mn-solutions.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] libertas: Fix ethtool statistics
Date: Fri, 18 Apr 2008 11:02:03 +0200 [thread overview]
Message-ID: <200804181102.03107.hs4233@mail.mn-solutions.de> (raw)
In-Reply-To: <1208448814.9212.270.camel@pmac.infradead.org>
NACK.
When I apply this patch and do "ethtool -S eth1", I get this:
$ ethtool -S eth1
NIC statistics:
=A0 =A0 =A0drop_duplicate_bcast: 7
=A0 =A0 =A0drop_ttl_zero: 0
=A0 =A0 =A0drop_no_fwd_route: 0
=A0 =A0 =A0drop_no_buffers: 9223372036854775808
=A0 =A0 =A0fwded_unicast_cnt: 0
=A0 =A0 =A0fwded_bcast_cnt: 0
=A0 =A0 =A0drop_blind_table: 0
=A0 =A0 =A0tx_failed_cnt: 9223372036854775808
But more severely, I get this in dmesg:
libertas enter: lbs_ethtool_get_stats()
libertas: PREP_CMD: command 0x009b failed: 2
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=
=A0 =A0 =A0 =A0 =A0
My firmware simply doesn't support the 009b command. It seems=20
also wrong to call an MESH related command on an struct=20
net_device *dev which is not priv->mesh_dev.
That ethtool returns junk like "9223372036854775808" is another=20
error. lbs_mesh_access() returned 2, and the code does "if (ret)=20
return ret". Maybe it should be like "if (ret) return -ENOSYS=20
(or some other ENOxxx) instead?
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-04-18 9:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-17 16:13 [PATCH] libertas: Fix ethtool statistics David Woodhouse
2008-04-17 18:02 ` Dan Williams
2008-04-17 19:44 ` Sebastian Siewior
2008-04-18 11:09 ` David Woodhouse
2008-05-10 7:24 ` [PATCH] [NET] libertas: check for mesh support before trying to use it Sebastian Siewior
2008-05-12 16:34 ` Dan Williams
2008-05-12 20:51 ` Sebastian Siewior
2008-05-13 0:09 ` John W. Linville
2008-04-18 9:02 ` Holger Schurig [this message]
2008-04-18 9:11 ` [PATCH] libertas: Fix ethtool statistics David Woodhouse
2008-04-18 9:49 ` Holger Schurig
2008-04-18 11:15 ` David Woodhouse
2008-04-18 13:10 ` Holger Schurig
2008-04-20 8:41 ` Sebastian Siewior
2008-04-20 10:56 ` David Woodhouse
2008-04-20 19:10 ` Sebastian Siewior
2008-04-21 6:42 ` David Woodhouse
-- strict thread matches above, loose matches on Subject: below --
2008-05-19 15:32 David Woodhouse
2008-05-19 15:47 ` Dan Williams
2008-05-19 17:20 ` Sebastian Siewior
2008-05-20 7:54 ` Holger Schurig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804181102.03107.hs4233@mail.mn-solutions.de \
--to=hs4233@mail.mn-solutions.de \
--cc=dwmw2@infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).