From: Holger Schurig <hs4233@mail.mn-solutions.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
libertas-dev@lists.infradead.org
Subject: Re: [PATCH] libertas: Fix ethtool statistics
Date: Fri, 18 Apr 2008 15:10:53 +0200 [thread overview]
Message-ID: <200804181510.53412.hs4233@mail.mn-solutions.de> (raw)
In-Reply-To: <1208517302.9212.324.camel@pmac.infradead.org>
> > I wrote "if (ret) return ret", not "if (ret) return;".
>
> I know you did, but I don't know why. The
> lbs_ethtool_get_stats() function returns void. Sebastian's
> patch which memsets it to zero makes sense, but it can't
> return an error.
Ahh, I stand corrected.
> They're separate problems, really. With or without the patch I
> first posted, you're getting crap back when you ask for
> statistics on a non-mesh device. The second patch fixes that,
> and stands alone.
Yes, this is separate. That's why I wrote "The ultimate patch
would be".
BTW, I like your two patches combined more than Sebastians memset
approach. Because with Sebastians patch on on ethX we would get
zeroed nonsense instead of uninitialized nonsense.
The memset should possible there anyway in the case of a firmware
that can mshX, but not CMD_ACT_MESH_GET_STATS or which would
return some error for another reason.
next prev parent reply other threads:[~2008-04-18 13:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-17 16:13 [PATCH] libertas: Fix ethtool statistics David Woodhouse
2008-04-17 18:02 ` Dan Williams
2008-04-17 19:44 ` Sebastian Siewior
2008-04-18 11:09 ` David Woodhouse
2008-05-10 7:24 ` [PATCH] [NET] libertas: check for mesh support before trying to use it Sebastian Siewior
2008-05-12 16:34 ` Dan Williams
2008-05-12 20:51 ` Sebastian Siewior
2008-05-13 0:09 ` John W. Linville
2008-04-18 9:02 ` [PATCH] libertas: Fix ethtool statistics Holger Schurig
2008-04-18 9:11 ` David Woodhouse
2008-04-18 9:49 ` Holger Schurig
2008-04-18 11:15 ` David Woodhouse
2008-04-18 13:10 ` Holger Schurig [this message]
2008-04-20 8:41 ` Sebastian Siewior
2008-04-20 10:56 ` David Woodhouse
2008-04-20 19:10 ` Sebastian Siewior
2008-04-21 6:42 ` David Woodhouse
-- strict thread matches above, loose matches on Subject: below --
2008-05-19 15:32 David Woodhouse
2008-05-19 15:47 ` Dan Williams
2008-05-19 17:20 ` Sebastian Siewior
2008-05-20 7:54 ` Holger Schurig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804181510.53412.hs4233@mail.mn-solutions.de \
--to=hs4233@mail.mn-solutions.de \
--cc=dwmw2@infradead.org \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).