w35und: one more unneccessary function

w35und: one more unneccessary function

[Pavel Machek]

Remove one more unnecessary function.

---
commit 8cf2b466620bd533acf20596be1fabfc0b46d992
tree e0bf7b039e545bede22980048669557fc49490e4
parent 6627ff26a459db3e792ec4dc194122c133c150a5
author Pavel <pavel@amd.ucw.cz> Sat, 19 Apr 2008 21:41:31 +0200
committer Pavel <pavel@amd.ucw.cz> Sat, 19 Apr 2008 21:41:31 +0200

 .../net/wireless/winbond/winbondport/mlmetxrx.c    |   57 -----------------------
 1 files changed, 0 insertions(+), 57 deletions(-)

diff --git a/drivers/net/wireless/winbond/winbondport/mlmetxrx.c b/drivers/net/wireless/winbond/winbondport/mlmetxrx.c
index dcfdfd4..f58e458 100644
--- a/drivers/net/wireless/winbond/winbondport/mlmetxrx.c
+++ b/drivers/net/wireless/winbond/winbondport/mlmetxrx.c
@@ -298,62 +298,5 @@ MLMERcvFrame(
 	#endif
     return;
 }
-#ifdef _IBSS_BEACON_SEQ_STICK_
-s8 SendBCNullData(PWB32_ADAPTER Adapter, u16 wIdx)
-{
-
-	PUCHAR	msg;
-	struct Data_Frame* msgHeader;
-
-	if ((msg=MLMEGetMMPDUBuffer(Adapter))==NULL)
-	{
-		Adapter->sMlmeFrame.wNumTxMMPDUDiscarded++;
-		return -1;  // fail get free msg buffer
-	}
-	//wConnectIdx = psLOCAL->wConnectedSTAindex;
-	msgHeader = (struct Data_Frame *) &msg[0];
-
-	// setup Frame-Header subfields
-	msgHeader->frame_control.mac_frame_info = MAC_SUBTYPE_DATA_NULL;
-	if (psBSS(wIdx)->bBssType == ESS_NET)
-	    msgHeader->frame_control.to_ds      = 1;
-	else
-	    msgHeader->frame_control.to_ds      = 0;
-    msgHeader->frame_control.from_ds    = 0;
-	msgHeader->frame_control.more_frag 	= 0;
-    msgHeader->frame_control.retry      = 0;
-	msgHeader->frame_control.more_data 	= 0;
-    msgHeader->frame_control.order      = 0;
-	//if (PowerMode  == PWR_SAVE)
-	//    msgHeader->frame_control.pwr_mgt    = 1;
-	//else
-    	msgHeader->frame_control.pwr_mgt    = 0;
-    msgHeader->frame_control.WEP        = 0;
-    msgHeader->duration                 = 0;    // Set by the MDS
-	
-	//memcpy(msgHeader->Addr1, psBSS(Adapter->sLocalPara.wConnectedSTAindex)->abBssID,MAC_ADDR_LENGTH);
-	memcpy( msgHeader->Addr1, "\xff\xff\xff\xff\xff\xff", MAC_ADDR_LENGTH );
-	//memset(msgHeader->Addr1, 0x55, MAC_ADDR_LENGTH);
-	memcpy( msgHeader->Addr2, Adapter->sLocalPara.ThisMacAddress, MAC_ADDR_LENGTH );
-	memcpy( msgHeader->Addr3, psBSS(wIdx)->abBssID, MAC_ADDR_LENGTH );
-	// FrameSequenceNumber is generated by HW-MAC
-
-	OS_MEMORY_CLEAR( &msgHeader->Sequence_Control, MAC_ADDR_LENGTH );
-
-    // now send this message out
-	if (1 == MLMESendFrame( Adapter,
-					(u8 *) &msg[0],
-					//sizeof(struct Data_Frame) - 6,
-					sizeof(struct Data_Frame),
-					FRAME_TYPE_802_11_DATA))
-        return 1;                           // Has sent to the Tx handler.
-	else
-	{
-		//return MLME buffer
-		MLMEfreeMMPDUBuffer(Adapter, msg);
-		return -1;
-	}
-}
-#endif
 
 

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: w35und: one more unneccessary function

[Luis R. Rodriguez]

On Sat, Apr 19, 2008 at 12:42 PM, Pavel Machek <pavel@ucw.cz> wrote:
> Remove one more unnecessary function.
>
>  ---
>  commit 8cf2b466620bd533acf20596be1fabfc0b46d992
>  tree e0bf7b039e545bede22980048669557fc49490e4
>  parent 6627ff26a459db3e792ec4dc194122c133c150a5
>  author Pavel <pavel@amd.ucw.cz> Sat, 19 Apr 2008 21:41:31 +0200
>  committer Pavel <pavel@amd.ucw.cz> Sat, 19 Apr 2008 21:41:31 +0200
>
>   .../net/wireless/winbond/winbondport/mlmetxrx.c    |   57 -----------------------
>   1 files changed, 0 insertions(+), 57 deletions(-)
>
>  diff --git a/drivers/net/wireless/winbond/winbondport/mlmetxrx.c b/drivers/net/wireless/winbond/winbondport/mlmetxrx.c
>  index dcfdfd4..f58e458 100644
>  --- a/drivers/net/wireless/winbond/winbondport/mlmetxrx.c
>  +++ b/drivers/net/wireless/winbond/winbondport/mlmetxrx.c

drivers/net/wireless/winbond/ ? What tree is this in?

  Luis

Re: w35und: one more unneccessary function

[Pavel Machek]

Hi!

> > Remove one more unnecessary function.
> >
> >  ---
> >  commit 8cf2b466620bd533acf20596be1fabfc0b46d992
> >  tree e0bf7b039e545bede22980048669557fc49490e4
> >  parent 6627ff26a459db3e792ec4dc194122c133c150a5
> >  author Pavel <pavel@amd.ucw.cz> Sat, 19 Apr 2008 21:41:31 +0200
> >  committer Pavel <pavel@amd.ucw.cz> Sat, 19 Apr 2008 21:41:31 +0200
> >
> >   .../net/wireless/winbond/winbondport/mlmetxrx.c    |   57 -----------------------
> >   1 files changed, 0 insertions(+), 57 deletions(-)
> >
> >  diff --git a/drivers/net/wireless/winbond/winbondport/mlmetxrx.c b/drivers/net/wireless/winbond/winbondport/mlmetxrx.c
> >  index dcfdfd4..f58e458 100644
> >  --- a/drivers/net/wireless/winbond/winbondport/mlmetxrx.c
> >  +++ b/drivers/net/wireless/winbond/winbondport/mlmetxrx.c
> 
> drivers/net/wireless/winbond/ ? What tree is this in?

My tree :-). It should be in some branch at code.google, too, and I
can do a full diff against vanilla if there's interest.

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: w35und: one more unneccessary function

[Luis R. Rodriguez]

On Sun, Apr 27, 2008 at 11:13 AM, Pavel Machek <pavel@ucw.cz> wrote:
> Hi!
>
>
>
>  > > Remove one more unnecessary function.
>  > >
>  > >  ---
>  > >  commit 8cf2b466620bd533acf20596be1fabfc0b46d992
>  > >  tree e0bf7b039e545bede22980048669557fc49490e4
>  > >  parent 6627ff26a459db3e792ec4dc194122c133c150a5
>  > >  author Pavel <pavel@amd.ucw.cz> Sat, 19 Apr 2008 21:41:31 +0200
>  > >  committer Pavel <pavel@amd.ucw.cz> Sat, 19 Apr 2008 21:41:31 +0200
>  > >
>  > >   .../net/wireless/winbond/winbondport/mlmetxrx.c    |   57 -----------------------
>  > >   1 files changed, 0 insertions(+), 57 deletions(-)
>  > >
>  > >  diff --git a/drivers/net/wireless/winbond/winbondport/mlmetxrx.c b/drivers/net/wireless/winbond/winbondport/mlmetxrx.c
>  > >  index dcfdfd4..f58e458 100644
>  > >  --- a/drivers/net/wireless/winbond/winbondport/mlmetxrx.c
>  > >  +++ b/drivers/net/wireless/winbond/winbondport/mlmetxrx.c
>  >
>  > drivers/net/wireless/winbond/ ? What tree is this in?
>
>  My tree :-). It should be in some branch at code.google, too, and I
>  can do a full diff against vanilla if there's interest.

Cool :) You seem to have quite a few trees. Which tree is it on? What
is the winbond driver? I guess I also don't understand the diffs
against your own tree on this list if we don't have much info for this
winbond driver or if its not merged yet. Is there a project link where
we can read a bit more about this driver and hardware it supports?

  Luis

Re: w35und: one more unneccessary function

[Károly Kasza]

>  >  > drivers/net/wireless/winbond/ ? What tree is this in?
>  >
>  >  My tree :-). It should be in some branch at code.google, too, and I
>  >  can do a full diff against vanilla if there's interest.
>
>  Cool :) You seem to have quite a few trees. Which tree is it on? What
>  is the winbond driver? I guess I also don't understand the diffs
>  against your own tree on this list if we don't have much info for this
>  winbond driver or if its not merged yet. Is there a project link where
>  we can read a bit more about this driver and hardware it supports?

Hi,

Pavel's tree can be mostly checked out from
http://winbondport.googlecode.com/svn/branches/pavel , however it may
be incomplete, because I can't always correctly apply the patches he
sends against the previous ones... It is based on an old and lousy
written driver (which works, but written in WEXT), and getting to work
in softmac. The old driver can be found at the above svn too, rev 2.

The chip is the W89C35 (IS89C35) USB2WLAN adapter found in many UMPCs
(koshinja, vye, packard bell) and other integrated stuff. Both of us
got an Airoha 2230 RF chip with it. The eeprom should be 93cx6
compatible, but I'm not sure.

Some of us are trying to write a whole new driver fully dropping the
old one in softmac too. Anyways, at least soon this device should be
supported in vanilla too.

KK